Skip to content
This repository was archived by the owner on Sep 25, 2023. It is now read-only.

Chat commands falsely trigger for partial matches #293

Open
Qaomen opened this issue Dec 16, 2020 · 0 comments
Open

Chat commands falsely trigger for partial matches #293

Qaomen opened this issue Dec 16, 2020 · 0 comments
Labels
bug something isn't working server affects the server

Comments

@Qaomen
Copy link
Collaborator

Qaomen commented Dec 16, 2020

Expected behavior
The chat commands (e.g. !marble) only works when a user's message matches the command exactly. When additional attributes are added in the message, they are separated with whitespace from each other and the command itself.

Actual behavior
As long as the start of the message matches the command (e.g. !marblemarbleandevenmoremarble), the command is triggered.

Reproduction steps

  1. Go to the client page
  2. Type any valid chat command
  3. Add any text to the command without adding whitespace
  4. The command is triggered despite not fully matching

Additional context
It's not a feature-breaking bug at the moment, although it does muddy up attribute checks for marbles and might cause conflicts with similarly named commands in the future.

@Qaomen Qaomen added bug something isn't working server affects the server labels Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug something isn't working server affects the server
Projects
None yet
Development

No branches or pull requests

1 participant