Skip to content

Commit 7407394

Browse files
committed
Workaround printing issue
1 parent cda7b3d commit 7407394

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/mono.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,14 @@ jobs:
247247
run: |
248248
python ./modules/mono/build_scripts/build_assemblies.py --godot-output-dir=./bin
249249
250-
# We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
250+
# Compile with explicit flags.
251+
# `PYTHONIOENCODING` was needed due to certain characters the Godot build system might print (such as '∞'),
252+
# otherwise it makes the job fail with an encoding error.
251253
- name: Compilation
252254
env:
253255
SCONS_CACHE_MSVC_CONFIG: true
254256
run: |
257+
set PYTHONIOENCODING=utf8
255258
scons verbose=yes warnings=all werror=yes platform=windows tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=yes copy_mono_root=yes mono_static=yes "cache_path=${{github.workspace}}/.scons_cache/"
256259
257260
# TODO Enhancement: Run tests? Such tests are able to run from Godot 4.0 only

.github/workflows/windows.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
# Upload cache on completion and check it out now
7474
# Editing this is pretty dangerous for Windows since it can break and needs to be properly tested with a fresh cache.
7575
- name: Load .scons_cache directory
76-
id: windows-cache
76+
id: windows-cache-2
7777
#uses: ${{matrix.cache_action}}
7878
uses: actions/cache@v4
7979
with:
@@ -115,11 +115,14 @@ jobs:
115115
run:
116116
python modules/voxel/misc/instrument.py -d . -c modules/voxel/misc/instruments.json
117117

118-
# We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
118+
# Compile with explicit flags.
119+
# `PYTHONIOENCODING` was needed due to certain characters the Godot build system might print (such as '∞'),
120+
# otherwise it makes the job fail with an encoding error.
119121
# TODO Enhancement: we'd like to use `warnings=extra` with MSVC but Godot doesn't compile yet with that level of warnings.
120122
# See https://github.com/godotengine/godot/issues/66537
121123
- name: Compilation
122124
run: |
125+
set PYTHONIOENCODING=utf-8
123126
scons verbose=yes warnings=all werror=yes platform=windows tests=no target=${{matrix.target}} dev_build=no precision=${{matrix.precision}} tracy=${{matrix.tracy}} production=yes "cache_path=${{github.workspace}}/.scons_cache/"
124127
125128
- name: "Rename executable"

0 commit comments

Comments
 (0)