Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup is broken #3

Open
waltertamboer opened this issue Jan 31, 2025 · 3 comments
Open

Cleanup is broken #3

waltertamboer opened this issue Jan 31, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@waltertamboer
Copy link

Setting cleanup to true will remove ALL firewall rules. Not exactly what I expected ... :-)

@waltertamboer
Copy link
Author

After carefully readint all the documentation, I see now this is mentioned here.

I didn't read further than the features section:

Optional Cleanup: Automatically removes added rules after deployment when cleanup is set to true.

This implies that the only the added rule is removed, which is false.

@adnanjaw
Copy link
Owner

@waltertamboer Sorry :-) that you lost all your firewall rules. I wanted to implement a way to remove only the specifically added rules, but unfortunately, I didn't have time.

Optional Cleanup: Automatically removes added rules after deployment when cleanup is set to true.

This is not good—I will fix it. Do you have any suggestions on how I can implement that?

@adnanjaw adnanjaw self-assigned this Jan 31, 2025
@adnanjaw adnanjaw added the bug Something isn't working label Jan 31, 2025
@waltertamboer
Copy link
Author

Thanks for your reply.

No worries, I should have read better :-)

To avoid this happening to anyone else in the future, perhaps rephrase it like this?

Optional Cleanup: Automatically removes all firewall rules after deployment when cleanup is set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants