You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I followed the tutorial from here, this description mentioned using two methods to set up pobm. One with a provided conda env file and a method which involves installing from PyPi.
The conda env file specifies a pobm version of 1.0.1:
but the "pip install" method in the notebook installs the latest version (on PyPi: 1.2.0):
However these two versions have breaking changes and both differ from the version available in the main repo.
The main problems I found with the 1.2.0 version:
The env file installs the proper dependencies for pobm, however pip install does not, which causes errors in running the example file.
Looking into it further, the proper dependency versions are only mentioned in the requirements.txt which (as far as I know) does not get compiled into the package when building. And if the user installs the toolbox, without consulting the requirements.txt, the wrong versions will get installed. Since the newer numpy and scipy versions moved/deprecated certain functions, the toolbox will not work out of the box.
Steps to reproduce:
Create empty python venv
Run pip list
Package Version
---------- -------
pip 25.0.1
setuptools 65.5.0
+1. Running pip install numpy==1.21.6 or pip install scipy==1.7.3 fails.
ERROR: No matching distribution found for ...
+2. The "Requirements" section in README.md specifies: numpy > 1.18.2, scipy > 1.4.1
Some of these incompatibilities with the new versions of numpy and scipy are fixed in the github version of pobm, but further fixes need to be issued. Thankfully these are only small changes to imports or function names.
The other issues are related to the different pobm versions used in the example code and the version installed from pip. I may mention those on the other issues page.
My suggestions:
Update the implementations to work with modern versions of numpy and scipy
Upgrade the build system to use pyproject.toml or include every important dependency version in setup.py
Update documentation to mention the newer dependency versions
Release a new build with this updates
(Optionally: Update the example code to work with the latest pobm version)
The text was updated successfully, but these errors were encountered:
I followed the tutorial from here, this description mentioned using two methods to set up pobm. One with a provided conda env file and a method which involves installing from PyPi.
The conda env file specifies a pobm version of 1.0.1:
but the "pip install" method in the notebook installs the latest version (on PyPi: 1.2.0):
However these two versions have breaking changes and both differ from the version available in the main repo.
The main problems I found with the 1.2.0 version:
The env file installs the proper dependencies for pobm, however pip install does not, which causes errors in running the example file.
Looking into it further, the proper dependency versions are only mentioned in the
requirements.txt
which (as far as I know) does not get compiled into the package when building. And if the user installs the toolbox, without consulting therequirements.txt
, the wrong versions will get installed. Since the newer numpy and scipy versions moved/deprecated certain functions, the toolbox will not work out of the box.Steps to reproduce:
pip list
pip install pobm
pip list
Relevant versions specified in
requirements.txt
:+1. Running
pip install numpy==1.21.6
orpip install scipy==1.7.3
fails.+2. The "Requirements" section in
README.md
specifies: numpy > 1.18.2, scipy > 1.4.1Some of these incompatibilities with the new versions of numpy and scipy are fixed in the github version of pobm, but further fixes need to be issued. Thankfully these are only small changes to imports or function names.
The other issues are related to the different pobm versions used in the example code and the version installed from pip. I may mention those on the other issues page.
My suggestions:
pyproject.toml
or include every important dependency version insetup.py
The text was updated successfully, but these errors were encountered: