Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin_video_decoder_factory.h and builtin_video_encoder_factory.h are missing #73

Open
MaxIasat opened this issue Nov 6, 2018 · 5 comments

Comments

@MaxIasat
Copy link

MaxIasat commented Nov 6, 2018

Hello,

i was trying to build the peerconnection_client example from googles webrtc repository. But i was missing these two includes
#include <webrtc/api/video_codecs/builtin_video_decoder_factory.h>
#include <webrtc/api/video_codecs/builtin_video_encoder_factory.h>

Without these includes i can't build the app properly. Do you know why these files are missing?

Thank you and best regards
Maxim

@agouaillard
Copy link

it looks like this project is only supporting up to version 60+, while the files you are looking for have been added only 6 months ago (in the version 69 or 70 frame).
https://chromium.googlesource.com/external/webrtc/+log/HEAD/api/video_codecs/builtin_video_decoder_factory.cc

You need to catch up with approximately 5 revision, or 6 months of work, i.e. around 5200 commits.

@MaxIasat
Copy link
Author

MaxIasat commented Nov 6, 2018

Thank you for your fast reply.

What can i do in order to have the newest stable version of webrtc?

@agouaillard
Copy link

to answer your question as you wrote it: go to webrtc.org and follow the instructions.
If you wanted to get the newest stable version of webrtc "using aisouard project", then you need to update the latest line of /CMakeModules/Version.cmake and replace 60 by whatever version you want. It is VERY unlikely to work.

@MaxIasat
Copy link
Author

MaxIasat commented Nov 6, 2018

Ok, i see. Thank you. So, you mean that your project needs some adoptions in order to use 60+ versions. Is it right?

@agouaillard
Copy link

This is not my project, I'm just kindly helping where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants