Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements that could be made to pymapdl #2137

Open
4 of 8 tasks
germa89 opened this issue Jun 22, 2023 · 7 comments
Open
4 of 8 tasks

Possible improvements that could be made to pymapdl #2137

germa89 opened this issue Jun 22, 2023 · 7 comments

Comments

@germa89
Copy link
Collaborator

germa89 commented Jun 22, 2023

@germa89 @mikerife This issue suggests possible improvements that could be made to pymapdl:

  • an option in pymapdl.solve() to do some validation before calling the SOLVE function on the back end (e.g. make sure that nlgeom is on if there are contact elements)
# suggestion
def solve(self, validation=None):
    if validation:
        self._validate_solve()
    return self.run("SOLVE")

def _validate_solve(self):
    # activate nlgeom if contact is involved.
    pass
  • post-processing commands throw a helpful exception if there is no active result set loaded.
  • ET commands can write a warning if elements are already defined with the given id

Originally posted by @koubaa in #2123 (comment)

Further additions:
Also add:

@germa89

This comment was marked as outdated.

@mikerife
Copy link

I really feel that the SOLVE command needs to be left alone:

  1. MAPDL already has heurestics built in to set some solution settings based on model type and features. I don't know that PyMAPDL needs to add to these.

  2. It's not always correct to turn on large deformation, even with models with contact. At the very least it's hard to show the benefit of large deformation if we can't turn it off!

@koubaa
Copy link
Contributor

koubaa commented Jul 10, 2023

@mikerife what if it just printed out some suggestions, rather than throwing any error or changing the behavior of solve?

@mikerife
Copy link

Care should be used when looking at adding a warning to multiple ET commands using the same ET ID. Reusing ET IDs is standard procedure in one way load coupled multiphysics models. It can also be SOP when using the MESH200 elements. Maybe an option to turn on 'enhanced warnings' that would pick up this type of usage?

@mikerife
Copy link

@koubaa that a good idea (printing suggestions)!

@germa89

This comment was marked as outdated.

@germa89

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants