chore: linting

Author: antongolub

.github/workflows/test.yml

@@ -84,7 +84,7 @@ jobs:
     needs: build
     strategy:
       matrix:
-        node-version: [ 12, 14, 16, 18, 20 ]
+        node-version: [12, 14, 16, 18, 20]
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}

package.json

@@ -69,7 +69,7 @@
     "test:smoke:win32": "node ./test/smoke/win32.test.js",
     "test:smoke:cjs": "node ./test/smoke/node.test.cjs",
     "test:smoke:mjs": "node ./test/smoke/node.test.mjs",
-    "coverage": "c8 -x build/vendor.js -x 'test/**' -x scripts --check-coverage npm test",
+    "coverage": "c8 -x build/vendor.cjs -x 'test/**' -x scripts --check-coverage npm test",
     "circular": "madge --circular src/*",
     "version": "cat package.json | fx .version"
   },

scripts/build-js.mjs

@@ -50,19 +50,32 @@ const {
   cwd: _cwd,
 } = argv
 
-const plugins = [transformHookPlugin({
-  hooks: [{
-    on: 'end',
-    pattern: /\.cjs/,
-    transform(contents) {
-      return contents
-        .replaceAll('"node:', '"')
-        .replaceAll('require("stream/promises")', 'require("stream").promises')
-        .replaceAll('require("fs/promises")', 'require("fs").promises')
-        .replaceAll('}).prototype', '}).prototype || {}')
-    }
-  }]
-})]
+const plugins = [
+  transformHookPlugin({
+    hooks: [
+      {
+        on: 'end',
+        pattern: /\.cjs/,
+        transform(contents) {
+          return contents
+            .slice(
+              0,
+              contents.indexOf(
+                '// Annotate the CommonJS export names for ESM import in node:'
+              )
+            )
+            .replaceAll('"node:', '"')
+            .replaceAll(
+              'require("stream/promises")',
+              'require("stream").promises'
+            )
+            .replaceAll('require("fs/promises")', 'require("fs").promises')
+            .replaceAll('}).prototype', '}).prototype || {}')
+        },
+      },
+    ],
+  }),
+]
 const cwd = Array.isArray(_cwd) ? _cwd[_cwd.length - 1] : _cwd
 const entries = entry.split(/,\s?/)
 const entryPoints = entry.includes('*')
@@ -83,11 +96,13 @@ if (bundle === 'src') {
 }
 
 if (hybrid) {
-  plugins.push(hybridExportPlugin({
-    loader: 'import',
-    to: 'build',
-    toExt: '.js'
-  }))
+  plugins.push(
+    hybridExportPlugin({
+      loader: 'import',
+      to: 'build',
+      toExt: '.js',
+    })
+  )
 }
 
 const formats = format.split(',')
@@ -115,7 +130,7 @@ const esmConfig = {
   target: 'esnext',
   format: 'esm',
   outExtension: {
-    '.js': '.mjs'
+    '.js': '.mjs',
   },
   plugins,
   legalComments: license,
@@ -131,13 +146,13 @@ const cjsConfig = {
   format: 'cjs',
   banner: {},
   outExtension: {
-    '.js': '.cjs'
+    '.js': '.cjs',
   },
   // https://github.com/evanw/esbuild/issues/1633
   define: {
-    'import.meta.url': 'import_meta_url'
+    'import.meta.url': 'import_meta_url',
   },
-  inject: ['./scripts/import.meta.url-polyfill.js']
+  inject: ['./scripts/import.meta.url-polyfill.js'],
 }
 
 for (const format of formats) {

scripts/import.meta.url-polyfill.js

@@ -1,3 +1,5 @@
 export const import_meta_url =
-  typeof document === 'undefined' ? new (require('url'.replace('', '')).URL)('file:' + __filename).href :
-    (document.currentScript && document.currentScript.src || new URL('main.js', document.baseURI).href)
+  typeof document === 'undefined'
+    ? new (require('url'.replace('', '')).URL)('file:' + __filename).href
+    : (document.currentScript && document.currentScript.src) ||
+      new URL('main.js', document.baseURI).href

src/cli.ts

@@ -56,9 +56,9 @@ const argv = minimist(process.argv.slice(2), {
   boolean: ['version', 'help', 'quiet', 'verbose', 'install', 'repl'],
   alias: { e: 'eval', i: 'install', v: 'version', h: 'help' },
   stopEarly: true,
-});
+})
 
-(async function main() {
+;(async function main() {
   const globals = './globals.js'
   await import(globals)
   if (argv.verbose) $.verbose = true

src/vendor.ts

@@ -32,10 +32,12 @@ import { AbortController } from 'node-abort-controller'
 
 export { exec, buildCmd } from 'zurk/spawn'
 
-import _createRequire  from 'create-require'
+import _createRequire from 'create-require'
 import { URL } from 'url'
 
-export const createRequire = (_createRequire) as unknown as (filename: string | URL) => NodeRequire
+export const createRequire = _createRequire as unknown as (
+  filename: string | URL
+) => NodeRequire
 
 global.AbortController = global.AbortController || AbortController
 

test/extra.test.js

@@ -19,10 +19,7 @@ import { globby } from '../build/index.js'
 
 describe('extra', () => {
   test('every file should have a license', async () => {
-    const files = await globby([
-      '**/*.{js,mjs,ts}',
-      '!**/*-polyfill.js'
-    ], {
+    const files = await globby(['**/*.{js,mjs,ts}', '!**/*-polyfill.js'], {
       gitignore: true,
       onlyFiles: true,
       cwd: process.cwd(),