Skip to content

Commit 3798607

Browse files
authored
ci: apply zizmor suggestions (google#1067)
1 parent 73347ac commit 3798607

File tree

7 files changed

+37
-12
lines changed

7 files changed

+37
-12
lines changed

.github/workflows/codeql.yml

+2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ jobs:
3333
steps:
3434
- name: Checkout repository
3535
uses: actions/checkout@v4
36+
with:
37+
persist-credentials: false
3638

3739
- name: Initialize CodeQL
3840
uses: github/codeql-action/init@v3

.github/workflows/dev-publish.yml

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ jobs:
1414
id-token: write
1515
steps:
1616
- uses: actions/checkout@v4
17+
with:
18+
persist-credentials: false
1719
- uses: actions/setup-node@v4
1820
with:
1921
node-version: 22

.github/workflows/docs.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,16 @@ on:
44
release:
55
types: [created]
66

7-
permissions:
8-
contents: read
9-
pages: write
10-
id-token: write
11-
127
concurrency:
138
group: 'pages'
149
cancel-in-progress: false
1510

1611
jobs:
1712
deploy:
13+
permissions:
14+
contents: read
15+
pages: write
16+
id-token: write
1817
environment:
1918
name: github-pages
2019
url: ${{ steps.deployment.outputs.page_url }}
@@ -23,6 +22,7 @@ jobs:
2322
- name: Checkout
2423
uses: actions/checkout@v4
2524
with:
25+
persist-credentials: false
2626
ref: main
2727
- name: Setup Pages
2828
uses: actions/configure-pages@v3

.github/workflows/npm-publish.yml

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ jobs:
1616
id-token: write
1717
steps:
1818
- uses: actions/checkout@v4
19+
with:
20+
persist-credentials: false
1921
- uses: actions/setup-node@v4
2022
with:
2123
node-version: 22

.github/workflows/osv.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,12 @@ on:
2121
push:
2222
branches: ['main']
2323

24-
permissions:
25-
# Require writing security events to upload SARIF file to security tab
26-
security-events: write
27-
# Read commit contents
28-
contents: read
29-
3024
jobs:
3125
scan-scheduled:
3226
if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }}
27+
permissions:
28+
security-events: write
29+
contents: read
3330
uses: 'google/osv-scanner-action/.github/workflows/osv-scanner-reusable.yml@1f1242919d8a60496dd1874b24b62b2370ed4c78' # v1.7.1
3431
with:
3532
# Example of specifying custom arguments
@@ -39,6 +36,9 @@ jobs:
3936
./
4037
scan-pr:
4138
if: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}
39+
permissions:
40+
security-events: write
41+
contents: read
4242
uses: 'google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@1f1242919d8a60496dd1874b24b62b2370ed4c78' # v1.7.1
4343
with:
4444
# Example of specifying custom arguments

.github/workflows/test.yml

+18
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v4
17+
with:
18+
persist-credentials: false
1719

1820
- name: Use Node.js 22.x
1921
uses: actions/setup-node@v4
@@ -39,6 +41,8 @@ jobs:
3941
FORCE_COLOR: 3
4042
steps:
4143
- uses: actions/checkout@v4
44+
with:
45+
persist-credentials: false
4246

4347
- name: Use Node.js 22.x
4448
uses: actions/setup-node@v4
@@ -73,6 +77,8 @@ jobs:
7377

7478
steps:
7579
- uses: actions/checkout@v4
80+
with:
81+
persist-credentials: false
7682

7783
- name: Use Node.js 22.x
7884
uses: actions/setup-node@v4
@@ -96,6 +102,9 @@ jobs:
96102
needs: build
97103
steps:
98104
- uses: actions/checkout@v4
105+
with:
106+
persist-credentials: false
107+
99108
- name: Use Node.js 16.x
100109
uses: actions/setup-node@v4
101110
with:
@@ -115,6 +124,9 @@ jobs:
115124
needs: build
116125
steps:
117126
- uses: actions/checkout@v4
127+
with:
128+
persist-credentials: false
129+
118130
- name: Setup Bun
119131
uses: antongolub/action-setup-bun@v1
120132
- uses: actions/download-artifact@v4
@@ -135,6 +147,8 @@ jobs:
135147
deno-version: [v1.x, v2.x]
136148
steps:
137149
- uses: actions/checkout@v4
150+
with:
151+
persist-credentials: false
138152
- name: Setup Deno
139153
uses: denoland/setup-deno@v2
140154
with:
@@ -156,6 +170,8 @@ jobs:
156170
node-version: [12, 14, 16, 18, 20, 22, 22-nightly, 23]
157171
steps:
158172
- uses: actions/checkout@v4
173+
with:
174+
persist-credentials: false
159175
- name: Use Node.js ${{ matrix.node-version }}
160176
uses: actions/setup-node@v4
161177
with:
@@ -179,6 +195,8 @@ jobs:
179195
ts: [4, 5, rc]
180196
steps:
181197
- uses: actions/checkout@v4
198+
with:
199+
persist-credentials: false
182200
- name: Use Node.js 22.x
183201
uses: actions/setup-node@v4
184202
with:

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@
8989
"test:smoke:win32": "node ./test/smoke/win32.test.js",
9090
"test:smoke:cjs": "node ./test/smoke/node.test.cjs",
9191
"test:smoke:mjs": "node ./test/smoke/node.test.mjs",
92-
"test:smoke:deno": "deno test ./test/smoke/deno.test.js --allow-read --allow-sys --allow-env --allow-run"
92+
"test:smoke:deno": "deno test ./test/smoke/deno.test.js --allow-read --allow-sys --allow-env --allow-run",
93+
"test:workflow": "zizmor .github/workflows -v -p"
9394
},
9495
"optionalDependencies": {
9596
"@types/fs-extra": ">=11",

0 commit comments

Comments
 (0)