Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous warning on unset options during FFI table operation #15565

Open
timsaucer opened this issue Apr 3, 2025 · 1 comment · May be fixed by #15579
Open

Erroneous warning on unset options during FFI table operation #15565

timsaucer opened this issue Apr 3, 2025 · 1 comment · May be fixed by #15579
Assignees
Labels
bug Something isn't working

Comments

@timsaucer
Copy link
Contributor

Describe the bug

When you use an FFI Table Provider, we create a session context by parsing a string representation of a session config. This happens in this line.

The problem is this is setting a deprecated option enable_options_value_normalization to the same value it already has. This generates a warning even though we aren't actually changing the value. This line is where we generate the warning.

This warning is erroneous and confusing to the user.

To Reproduce

Create a config. Set this value to the same as it already has. Warning will be generated.

Expected behavior

We probably do want the warning any time a user tries to set the variable, even if to the default. So instead what we may want to do is when creating a session config from a hash table of key/value pairs remove any that are not the same as the defaults.

Additional context

No response

@timsaucer timsaucer added the bug Something isn't working label Apr 3, 2025
@chenkovsky
Copy link
Contributor

take

@chenkovsky chenkovsky linked a pull request Apr 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants