Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve time for SortPreservingMerge stream / uninitiated_partitions VecDeque<usize> #15573

Closed
Tracked by #15271
alamb opened this issue Apr 3, 2025 · 3 comments · Fixed by #15562
Closed
Tracked by #15271

Improve time for SortPreservingMerge stream / uninitiated_partitions VecDeque<usize> #15573

alamb opened this issue Apr 3, 2025 · 3 comments · Fixed by #15562
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Apr 3, 2025

Is your feature request related to a problem or challenge?

Both @rluvaton and I have seen

Image

Image

I saw this when running the following query

./datafusion-cli-filter-pushdown -c "SELECT \"WatchID\", \"ClientIP\", COUNT(*) AS c, SUM(\"IsRefresh\"), AVG(\"ResolutionWidth\") FROM hits WHERE \"SearchPhrase\" <> '' GROUP BY \"WatchID\", \"ClientIP\" ORDER BY c DESC LIMIT 10;"

Using hits.parquet: https://datasets.clickhouse.com/hits_compatible/hits.parquet

I am not sure what @rluvaton was doing when he saw it

Describe the solution you'd like

Review and see if this is a performance bottleneck we can remove

Describe alternatives you've considered

No response

Additional context

No response

@alamb
Copy link
Contributor Author

alamb commented Apr 3, 2025

@Rachelint
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Apr 4, 2025

FYI @Rachelint I think @rluvaton has a proposal on a ticket as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants