Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] recommended to support label selection when monitoring threshold rules #3185

Open
gaows20 opened this issue Mar 28, 2025 · 13 comments
Open
Assignees

Comments

@gaows20
Copy link

gaows20 commented Mar 28, 2025

Description

1.7.0版本 阈值规则关联监控时建议支持按label选择,设备太多时挨个选择太繁琐。

Task List

1: 1.7.0版本阈值规则关联监控时建议支持按label选择

@LL-LIN
Copy link
Contributor

LL-LIN commented Mar 30, 2025

You can refer to:
#3161

@bigcyy
Copy link
Contributor

bigcyy commented Apr 2, 2025

Please assign it to me, I will complete it.

@tomsun28
Copy link
Contributor

tomsun28 commented Apr 2, 2025

Please assign it to me, I will complete it.

welcome.

@tomsun28 tomsun28 changed the title [Task] <title>1.7.0版本阈值规则关联监控时建议支持按label选择 [Task] recommended to support label selection when monitoring threshold rules Apr 2, 2025
@tomsun28
Copy link
Contributor

tomsun28 commented Apr 2, 2025

Please assign it to me, I will complete it.

hi, Is the plan to replace the previous one with labels, or will both methods exist?

Suggest also put the label association in the Alert Threshold Association modal box.
Image

@bigcyy
Copy link
Contributor

bigcyy commented Apr 2, 2025

when selecting monitoring, you can filter directly through tags.

lable_filter.mp4

@bigcyy
Copy link
Contributor

bigcyy commented Apr 2, 2025

My understanding:

  • Filter selectable monitoring options through labels, allowing users to sift through numerous monitoring options to find those with specific labels (users may want to select only a portion, rather than selecting all by labels).
  • Associate all monitoring options with a particular label through tagging to reduce expression length and minimize the number of selections users need to make.

Next, I will put the label association in the Alert Threshold Association modal box.

@tomsun28
Copy link
Contributor

tomsun28 commented Apr 3, 2025

@gaows20 Hi, is this what you mean? I thought it was label matching, not label filtering. The label matching is to directly associate the threshold rule with the corresponding monitored label by configuring the label, and finally calculate the threshold. Similar to the expression generated at the end, it contains label match expr like contains(__labels__, 'banana'), eg: equals(__app__,"website") && equals(__metrics__,"summary") && contains(__labels__, 'banana'). This situation can also simplify the problem of having thousands of monitoring points to be selected.

@gaows20
Copy link
Author

gaows20 commented Apr 3, 2025

我目前需要的是:标签匹配。某个标签下有600个设备,把这个标签下所有设备都放在一个阈值规则。这和我提的那个超过46条添加失败差不多属于一个问题。当然我感觉这个标签过滤也是一个非常好的功能。以后可能会用到。

@bigcyy
Copy link
Contributor

bigcyy commented Apr 3, 2025

Thank you, Tom and gaows20, for your clarification. I will add label filtering and label matching.

@tomsun28
Copy link
Contributor

tomsun28 commented Apr 3, 2025

👍 so according to the conversation, seems this is no need to update expr length, or we can update @Size(max = 2048) @Column(length = 2048) to 4096 and remove the update sql(Flyway sql may sometimes fail to start in different environments. Try not to use it if it is not necessary.) #3198

@bigcyy
Copy link
Contributor

bigcyy commented Apr 3, 2025

@tomsun28 2048 characters can support approximately 60 individual expressions. If we need to modify Column(length = 2048), we must also update the Flyway SQL. I believe we don’t need to increase the column length for now. Should I close PR #3198?

@tomsun28
Copy link
Contributor

tomsun28 commented Apr 5, 2025

@tomsun28 2048 characters can support approximately 60 individual expressions. If we need to modify Column(length = 2048), we must also update the Flyway SQL. I believe we don’t need to increase the column length for now. Should I close PR #3198?

hi ok we can close it.

@gaows20 gaows20 closed this as completed Apr 5, 2025
@gaows20
Copy link
Author

gaows20 commented Apr 5, 2025

。。。点错了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants