fix(graphql): property security might be cached w/ different objects

soyuka · soyuka · commit 2e20c6379191 · 2025-04-03T17:03:12.000+02:00
diff --git a/Serializer/ItemNormalizer.php b/Serializer/ItemNormalizer.php
@@ -89,6 +89,8 @@ public function normalize(mixed $object, ?string $format = null, array $context
 
         if ($this->isCacheKeySafe($context)) {
             $context['cache_key'] = $this->getCacheKey($format, $context);
+        } else {
+            $context['cache_key'] = false;
         }
 
         unset($context['operation_name'], $context['operation']); // Remove operation and operation_name only when cache key has been created

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,8 @@ public function normalize(mixed $object, ?string $format = null, array $context`
`89`	`89`
`90`	`90`	`if ($this->isCacheKeySafe($context)) {`
`91`	`91`	`$context['cache_key'] = $this->getCacheKey($format, $context);`
	`92`	`+ } else {`
	`93`	`+ $context['cache_key'] = false;`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`unset($context['operation_name'], $context['operation']); // Remove operation and operation_name only when cache key has been created`