-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Enum-like objects #1833
Comments
We decided in the team call today that we should target deprecating these for the beta, and remove them at a later stage. The deprecation should will print a warn-level message advising users that they should consider switching to string unions soon. We will then remove them in a future update. The deprecation is tracked by #2621. |
From looking in to this, it seems that the objects we used to use were generated by protobuf. I'm not sure what we actually want to remove here, since they are still used for rpc. |
This is incorrect, the Enum-like objects are hand-written at https://github.com/arcjet/arcjet-js/blob/main/protocol/index.ts These all use ArcjetEnum |
These were deprecated in #2684 and will be removed in the 1.0.0 release. |
The initial design of the SDK used TypeScript enums for various configuration. We've removed those in favor of string unions, which fit more naturally with the way people write both TypeScript and JavaScript. However, we kept around objects that behaved like the enums for migration. Our docs haven't recommended those for a long time, and we're moving towards string values that translate directly to Wasm via jco.
We should deprecate and remove these.
The text was updated successfully, but these errors were encountered: