ManualMapper refactoring to keep the first place

Author: arey

benchmark.plt

@@ -28,5 +28,5 @@ set style line 2 lc rgb '#808080' lt 1
 set border 3 back ls 2
 set tics nomirror
 
-plot 'results.csv' every ::1 using 0:5:xticlabels(stringcolumn(1)[41:60]) with boxes ls 1,\
+plot 'results.csv' every ::1 using 0:5:xticlabels(8) with boxes ls 1,\
      'results.csv' every ::1 using 0:($5 + 1500):(sprintf("%d",$5)) with labels offset char 0,1

readme.md

@@ -36,7 +36,7 @@ It includes combinations which usually appear in Java Beans, such as:
 
 ## Launch the benchmark
 
-_Pre-requisites: Maven 3.x and a JDK 6 (or above)_
+_Pre-requisites: Maven 3.x and a JDK 7 (or above)_
 
 ``git clone git://github.com/arey/java-object-mapper-benchmark.git``
 
@@ -65,28 +65,32 @@ Tests has been performed on:
         <th>Benchmark</th><th>Mode</th><th>Samples</th><th>Score</th><th>Margin error (+/-)</th><th>Units</th>
     </tr>
     <tr>
-        <th>Manual</th><td>thrpt</td><td>200</td><td>18 047 670</td><td>70 665</td><td>ops/s</td>
-    </tr>
-    <tr>
-        <th>Selma</th><td>thrpt</td><td>200</td><td>16 467 211</td><td>63 445</td><td>ops/s</td>
+        <th>Manual</th><td>thrpt</td><td>200</td><td>27 598 750</td><td>346 265</td><td>ops/s</td>
     </tr>
     <tr>        
-        <th>MapStruct</th><td>thrpt</td><td>200</td><td>15 266 378</td><td>125 660</td><td>ops/s</td>
+        <th>MapStruct</th><td>thrpt</td><td>200</td><td>27 206 021</td><td>133 009</td><td>ops/s</td>
+    </tr>
+    <tr>
+        <th>Selma</th><td>thrpt</td><td>200</td><td>26 205 612</td><td>185 326</td><td>ops/s</td>
     </tr>
     <tr>
-        <th>JMapper</th><td>thrpt</td><td>200</td><td>15 487 461</td><td>119 421</td><td>ops/s</td>
+        <th>JMapper</th><td>thrpt</td><td>200</td><td>23 377 962</td><td>124 537</td><td>ops/s</td>
     </tr>
     <tr>
-        <th>Orika</th><td>thrpt</td><td>200</td><td>3 522 891</td><td>40 734</td><td>ops/s</td>
+        <th>Orika</th><td>thrpt</td><td>200</td><td>4 097 030</td><td>21 220</td><td>ops/s</td>
     </tr>
     <tr>       
-        <th>ModelMaper</th><td>thrpt</td><td>200</td><td>253 658</td><td>2 197</td><td>ops/s</td>
+        <th>ModelMaper</th><td>thrpt</td><td>200</td><td>323 791</td><td>3 172</td><td>ops/s</td>
     </tr>
     <tr>
-        <th>Dozer</th><td>thrpt</td><td>200</td><td>83 274</td><td>724</td><td>ops/s</td>
+        <th>Dozer</th><td>thrpt</td><td>200</td><td>84 113</td><td>331</td><td>ops/s</td>
     </tr>
 </table>
 
+
+"Benchmark","Mode","Threads","Samples","Score","Score Error (99,9%)","Unit","Param: type"
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"26095841,101453","245410,911251","ops/s",Selma
+
 ![Framework Comparison](results.png)
 
 

results.csv

@@ -1,8 +1,8 @@
 "Benchmark","Mode","Threads","Samples","Score","Score Error (99,9%)","Unit","Param: type"
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"60674,682344","866,863148","ops/s",DozerMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"22157250,519310","126894,016482","ops/s",JMapperMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"28151869,510388","743117,415160","ops/s",ManualMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"24391686,608522","381298,226400","ops/s",MapStructMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"200161,330064","3685,229185","ops/s",ModelMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"2617240,822837","20547,290629","ops/s",OrikaMapper
-"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,5,"26874373,657715","112287,003423","ops/s",SelmaMapper
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"27598750,161992","346265,704225","ops/s",Manual
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"27206021,062526","133009,298251","ops/s",MapStruct
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"26205612,876587","185326,677688","ops/s",Selma
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"23377962,917915","124537,993554","ops/s",JMapper
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"4097030,344104","21220,567480","ops/s",Orika
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"323791,972104","3172,754252","ops/s",ModelMapper
+"com.javaetmoi.benchmark.MapperBenchmark.mapper","thrpt",1,200,"84113,220613","331,664883","ops/s",Dozer

results.png

@@ -27,7 +27,7 @@
 @State(Scope.Benchmark)
 public class MapperBenchmark {
 
-    @Param({"DozerMapper", "JMapperMapper", "ManualMapper", "MapStructMapper", "ModelMapper", "OrikaMapper",  "SelmaMapper"})
+    @Param({"Manual", "MapStruct",  "Selma", "JMapper", "Orika", "ModelMapper", "Dozer"})
     private String type;
 
     private OrderMapper mapper;
@@ -36,25 +36,25 @@ public class MapperBenchmark {
     @Setup(Level.Trial)
     public void setup(){
         switch (type) {
-            case "DozerMapper":
+            case "Dozer":
                 mapper = new DozerMapper();
                 break;
-            case "OrikaMapper":
+            case "Orika":
                 mapper = new OrikaMapper();
                 break;
             case "ModelMapper":
                 mapper = new ModelMapper();
                 break;
-            case "MapStructMapper":
+            case "MapStruct":
                 mapper = new MapStructMapper();
                 break;
-            case "SelmaMapper":
+            case "Selma":
                 mapper = new SelmaMapper();
                 break;
-            case "JMapperMapper":
+            case "JMapper":
                 mapper = new JMapperMapper();
                 break;
-            case "ManualMapper":
+            case "Manual":
                 mapper = new ManualMapper();
                 break;
             default:

src/main/java/com/javaetmoi/benchmark/MapperBenchmark.java

@@ -20,35 +20,23 @@ public OrderDTO map(Order source) {
         Customer customer = source.getCustomer();
         if (customer != null) {
             target.setCustomerName(customer.getName());
-            mapBillingAddress(target, customer.getBillingAddress());
-            mapShippingAddress(target, customer.getShippingAddress());
+            if (customer.getBillingAddress() != null) {
+                target.setBillingCity(customer.getBillingAddress().getCity());
+                target.setBillingStreetAddress(customer.getBillingAddress().getStreet());
+            }
+            if (customer.getShippingAddress() != null) {
+                target.setShippingCity(customer.getShippingAddress().getCity());
+                target.setShippingStreetAddress(customer.getShippingAddress().getStreet());
+            }
         }
-        mapProducts(source, target);
-        return target;
-    }
-
-    private void mapShippingAddress(OrderDTO target, Address shippingAddress) {
-        if (shippingAddress != null) {
-            target.setShippingCity(shippingAddress.getCity());
-            target.setShippingStreetAddress(shippingAddress.getStreet());
-        }
-    }
-
-    private void mapBillingAddress(OrderDTO target, Address billingAddress) {
-        if (billingAddress != null) {
-            target.setBillingCity(billingAddress.getCity());
-            target.setBillingStreetAddress(billingAddress.getStreet());
+        if (source.getProducts() != null) {
+            List<ProductDTO> targetProducts = new ArrayList<ProductDTO>(source.getProducts().size());
+            for (Product product : source.getProducts()) {
+                targetProducts.add(new ProductDTO(product.getName()));
+            }
+            target.setProducts(targetProducts);
         }
+        return target;
     }
 
-    private void mapProducts(Order source, OrderDTO target) {
-        if (source.getProducts() == null) {
-            return;
-        }
-        List<ProductDTO> targetProducts = new ArrayList<ProductDTO>(source.getProducts().size());
-        for (Product product : source.getProducts()) {
-            targetProducts.add(new ProductDTO(product.getName()));
-        }
-        target.setProducts(targetProducts);
-    }
 }