Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite revisionHistoryLimit for EventSource Deployment #3419

Open
coldagent opened this issue Jan 9, 2025 · 0 comments
Open

Overwrite revisionHistoryLimit for EventSource Deployment #3419

coldagent opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@coldagent
Copy link

Is your feature request related to a problem? Please describe.
When working on an eventsource the ArgoCD UI gets pretty messy showing all these old eventsource replica sets. It would be nice to be able to set the revisionHistoryLimit of the eventsource deployment.

Describe the solution you'd like
Use revisionHistoryLimit in eventsource to overwrite/set revisionHistoryLimit in eventsource deployment. I am using a simple webhook as an example

apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
  name: eventsource-name
spec:
  eventBusName: eventbus
  revisionHistoryLimit: 0
  webhook:
    example-webhook:
      port: "8080"
      endpoint: /example
      method: GET

Describe alternatives you've considered
Using a patch to override the revisionHistoryLimit for the eventsource deployment. Setting a global revisionHistoryLimit

Additional context
Similar/Related issue: #1786


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@coldagent coldagent added the enhancement New feature or request label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant