Implement midi learn for CC messages. Fix: #58

Author: asb2m10

Builds/MacOSX/Dexed.xcodeproj/project.pbxproj

@@ -19,6 +19,7 @@ Changelog
 ---------
 #### Version 0.9.4
 * Standalone application version of Dexed
+* Midi Learn support for midi CC messages
 * More accurate detune
 * More accurate EG envelopes. thanks @jeremybernstein
 * Fix implementation for Midi CC 120 and 123 (All Sound Off / All Notes Off)
@@ -86,7 +87,6 @@ TODO - Dexed
 
 TODO - msfa
 -----------
-* Better implementation of detune
 * Portamento implementation
 * Better Amplitude Modulation
 * Accurate live operator level envelope updates

Builds/MacOSX/Dexed.xcodeproj/project.xcworkspace/xcuserdata/asb2m10.xcuserdatad/UserInterfaceState.xcuserstate

@@ -335,6 +335,16 @@ void DexedAudioProcessor::getStateInformation(MemoryBlock& destData) {
     blobSet.set("program", var((void *) &data, 161));
 
     blobSet.copyToXmlAttributes(*dexedBlob);
+    
+    XmlElement *midiCC = dexedState.createNewChildElement("midiCC");
+    HashMap<int, Ctrl *>::Iterator i(mappedMidiCC);
+    while(i.next()) {
+        XmlElement *ccMapping = midiCC->createNewChildElement("mapping");
+        ccMapping->setAttribute("cc", i.getKey());
+        Ctrl *ctrl = i.getValue();
+        ccMapping->setAttribute("target", ctrl->label);
+    }
+    
     copyXmlToBinary(dexedState, destData);
 }
 
@@ -399,7 +409,26 @@ void DexedAudioProcessor::setStateInformation(const void* source, int sizeInByte
     loadCartridge(cart);
     memcpy(data, program.getBinaryData()->getData(), 161);
 
-    lastStateSave = (long) time(NULL);
+    mappedMidiCC.clear();
+    XmlElement *midiCC = root->getChildByName("midiCC");
+    if ( midiCC != nullptr ) {
+        XmlElement *ccMapping = midiCC->getFirstChildElement();
+        while (ccMapping != nullptr) {
+            int cc = ccMapping->getIntAttribute("cc", -1);
+            String target = ccMapping->getStringAttribute("target", "");
+            if ( target.isNotEmpty() && cc != -1 ) {
+                for(int i=0;i<ctrl.size();i++) {
+                    if ( ctrl[i]->label == target) {
+                        mappedMidiCC.set(cc, ctrl[i]);
+                        break;
+                    }
+                }
+            }
+            ccMapping->getNextElement();
+        }
+    }
+    
+    lastStateSave = (long) time(NULL);    
     TRACE("setting VST STATE");
     updateUI();
 }

Builds/MacOSX/Dexed.xcodeproj/xcuserdata/asb2m10.xcuserdatad/xcschemes/xcschememanagement.plist

@@ -35,7 +35,7 @@ DexedAudioProcessorEditor::DexedAudioProcessorEditor (DexedAudioProcessor* owner
     : AudioProcessorEditor (ownerFilter),
     midiKeyboard (ownerFilter->keyboardState, MidiKeyboardComponent::horizontalKeyboard),
     cartManager(this)
-{
+{
     lookAndFeel = DXLookNFeel::getLookAndFeel();
     LookAndFeel::setDefaultLookAndFeel(lookAndFeel);
 
@@ -95,8 +95,8 @@ DexedAudioProcessorEditor::DexedAudioProcessorEditor (DexedAudioProcessor* owner
 
 DexedAudioProcessorEditor::~DexedAudioProcessorEditor() {
     stopTimer();
-    processor->unbindUI();
-    setLookAndFeel(nullptr);
+    processor->unbindUI();
+    setLookAndFeel(nullptr);
 }
 
 //==============================================================================
@@ -341,3 +341,33 @@ void DexedAudioProcessorEditor::storeProgram() {
         delete externalFile;
     cartManager.resetActiveSysex();
 }
+
+class MidiCCListener: public AlertWindow, Value::Listener {
+    DexedAudioProcessorEditor *editor;
+    Ctrl *target;
+public :
+    MidiCCListener(DexedAudioProcessorEditor *editor, Ctrl *target) : AlertWindow("","Waiting for midi CC (controller change) message ...", AlertWindow::InfoIcon, editor) {
+        this->editor = editor;
+        this->target = target;
+        addButton("Cancel", -1);
+        editor->processor->lastCCUsed.addListener(this);
+    }
+    
+    ~MidiCCListener() {
+        editor->processor->lastCCUsed.removeListener(this);
+    }
+    
+    void valueChanged(Value &value) {
+        int cc = value.getValue();
+        editor->processor->mappedMidiCC.remove(cc);
+        editor->processor->mappedMidiCC.set(cc, target);
+        editor->processor->savePreference();
+        exitModalState(0);
+    }
+};
+
+void DexedAudioProcessorEditor::discoverMidiCC(Ctrl *ctrl) {
+    MidiCCListener ccListener(this, ctrl);
+    ccListener.runModalLoop();
+}
+

Builds/MacOSX/Icon.icns

@@ -36,7 +36,7 @@ class DexedAudioProcessorEditor  : public AudioProcessorEditor, public ComboBox:
     OperatorEditor operators[6];
     Colour background;
     CartManager cartManager;
-    ScopedPointer<DXLookNFeel> lookAndFeel;
+    ScopedPointer<DXLookNFeel> lookAndFeel;
 
 public:
     DexedAudioProcessor *processor;
@@ -55,7 +55,8 @@ class DexedAudioProcessorEditor  : public AudioProcessorEditor, public ComboBox:
     void initProgram();
     void storeProgram();
     void cartShow();
-    void parmShow();
+    void parmShow();
+    void discoverMidiCC(Ctrl *ctrl);
 };
 
 

Builds/VisualStudio2017/icon.ico

@@ -259,6 +259,33 @@ void Ctrl::mouseEnter(const juce::MouseEvent &event) {
     updateDisplayName();
 }
 
+void Ctrl::mouseDown(const juce::MouseEvent &event) {
+    if ( event.mods.isRightButtonDown() || event.mods.isAnyModifierKeyDown()) {
+        PopupMenu popup;
+        
+        if ( parent->mappedMidiCC.containsValue(this) ) {
+            popup.addItem(1, "Remove midi CC mapping for this controller");
+            popup.addSeparator();
+        }
+        popup.addItem(2, "Map controller to midi CC");
+        
+        switch(popup.show()) {
+            case 1:
+                parent->mappedMidiCC.removeValue(this);
+                parent->savePreference();
+                break;
+            case 2:
+                AudioProcessorEditor *editor = parent->getActiveEditor();
+                if ( editor == NULL ) {
+                    return;
+                }
+                DexedAudioProcessorEditor *dexedEditor = (DexedAudioProcessorEditor *) editor;
+                dexedEditor->discoverMidiCC(this);
+                break;
+        }
+    }
+}
+
 void Ctrl::updateDisplayName() {
 }
 

LICENSE

@@ -58,6 +58,7 @@ class Ctrl : public Slider::Listener, public Button::Listener, public ComboBox::
     void sliderValueChanged (Slider* moved);
     void buttonClicked (Button* buttonThatWasClicked);
     void mouseEnter(const MouseEvent &event);
+    void mouseDown(const MouseEvent &event);
     virtual void updateDisplayName();
 
     /**

README.md

@@ -93,12 +93,12 @@ DexedAudioProcessor::DexedAudioProcessor() {
     clipboardContent = -1;
 }
 
-DexedAudioProcessor::~DexedAudioProcessor() {
-    Logger *tmp = Logger::getCurrentLogger();
-	if ( tmp != NULL ) {
-		Logger::setCurrentLogger(NULL);
-		delete tmp;
-	}
+DexedAudioProcessor::~DexedAudioProcessor() {
+    Logger *tmp = Logger::getCurrentLogger();
+	if ( tmp != NULL ) {
+		Logger::setCurrentLogger(NULL);
+		delete tmp;
+	}
     TRACE("Bye");
 }
 
@@ -333,7 +333,14 @@ void DexedAudioProcessor::processMidiMessage(const MidiMessage *msg) {
                             keyup(voices[note].midi_note);
                     }
                     break;
-            }
+                default:
+                    if ( mappedMidiCC.contains(ctrl) ) {
+                        Ctrl *linkedCtrl = mappedMidiCC[ctrl];
+                        linkedCtrl->publishValue((float) value / 127);
+                    }
+                    // this is used to notify the dialog that a CC value was received.
+                    lastCCUsed.setValue(ctrl);
+                }
         }
         return;
 

Source/PluginData.cpp

@@ -137,6 +137,8 @@ public :
     int getEngineType();
     void setEngineType(int rs);
 
+    HashMap<int, Ctrl*> mappedMidiCC;
+    
     Array<Ctrl*> ctrl;
 
     OperatorCtrl opCtrl[6];
@@ -232,6 +234,8 @@ public :
 
     static File dexedAppDir;
     static File dexedCartDir;
+    
+    Value lastCCUsed;
 private:
     //==============================================================================
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (DexedAudioProcessor)