Skip to content

Rework venv activation #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eifinger opened this issue Mar 29, 2025 · 0 comments
Open

Rework venv activation #351

eifinger opened this issue Mar 29, 2025 · 0 comments
Labels
venv-activation Temporay label to track issues with first venv activation

Comments

@eifinger
Copy link
Collaborator

Problem

If python-version is defined, setup-uv currently auto-activates a venv under .venv in the repository/workspace root.

Problems with this behavior:

Other considerations:

Solutions

Solution 1

  • a new boolean input activate-environment
  • a new input working-directory which defaults to ${{ github.workspace }}. If activate-environment: true it will activate the venv in this place
  • We automatically look for pyproject.toml and .python-version in working-directory

Optional: We always install the target python version (determined by python-version, pyproject.toml or .python-version).

Open question: What to do about --system-site-packages?

@eifinger eifinger added the venv-activation Temporay label to track issues with first venv activation label Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
venv-activation Temporay label to track issues with first venv activation
Projects
None yet
Development

No branches or pull requests

1 participant