Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when copying on a system not running X #1707

Open
ellie opened this issue Feb 12, 2024 · 4 comments · May be fixed by #2648
Open

Panic when copying on a system not running X #1707

ellie opened this issue Feb 12, 2024 · 4 comments · May be fixed by #2648
Labels
bug Something isn't working

Comments

@ellie
Copy link
Member

ellie commented Feb 12, 2024

See more details:

https://forum.atuin.sh/t/error-when-copying-to-clipboard-without-x-server/157

Replication steps

  • Run on a machine without X (eg, SSH into a server)
  • ctrl-y on a history item to yank to clipboard
  • observe panic
thread 'main' panicked at atuin/src/command/client/search/interactive.rs:1013:36:
called `Result::unwrap()` on an `Err` value: XcbConnect(DisplayParsingError)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behaviour

Atuin should do nothing in an environment without a clipboard
@ellie ellie added the bug Something isn't working label Feb 12, 2024
@atuin-bot
Copy link

This issue has been mentioned on Atuin Community. There might be relevant details there:

https://forum.atuin.sh/t/error-when-copying-to-clipboard-without-x-server/157/2

@halostatue
Copy link

Adding support for OSC 52 might be useful for some cases, although it depends on the terminal application (I just learned about this, so…).

@jonasgeiler
Copy link

Same problem here on a clean Debian 12 installation over SSH... Let me know if you need details.

@dhth dhth linked a pull request Mar 25, 2025 that will close this issue
Draft
2 tasks
@dhth
Copy link
Contributor

dhth commented Mar 25, 2025

@ellie
Sent in a tiny change for this. Have a few follow up questions in the PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: don't panic if clipboard cannot be accessed dhth/atuin
5 participants
@halostatue @jonasgeiler @dhth @ellie @atuin-bot