eliminate an impossible error case from state.WriteState (#1473)

tsachiherman · darioush · web-flow · commit 8a40954d8070 · 2025-03-06T13:37:25.000+03:00
Signed-off-by: Tsachi Herman &lt;24438559+tsachiherman@users.noreply.github.com&gt;
Co-authored-by: Darioush Jalali &lt;darioush.jalali@avalabs.org&gt;
diff --git a/plugin/evm/validators/state/state.go b/plugin/evm/validators/state/state.go
@@ -197,13 +197,14 @@ func (s *state) WriteState() error {
 			if err := batch.Delete(vID[:]); err != nil {
 				return err
 			}
-		default:
-			return fmt.Errorf("unknown update status for %s", vID)
 		}
-		// we're done, remove the updated marker
-		delete(s.updatedData, vID)
 	}
-	return batch.Write()
+	if err := batch.Write(); err != nil {
+		return err
+	}
+	// we've successfully flushed the updates, clear the updated marker.
+	clear(s.updatedData)
+	return nil
 }
 
 // SetStatus sets the active status of the validator with the given vID

Original file line number	Diff line number	Diff line change
`@@ -197,13 +197,14 @@ func (s *state) WriteState() error {`
`197`	`197`	`if err := batch.Delete(vID[:]); err != nil {`
`198`	`198`	`return err`
`199`	`199`	`}`
`200`		`- default:`
`201`		`- return fmt.Errorf("unknown update status for %s", vID)`
`202`	`200`	`}`
`203`		`- // we're done, remove the updated marker`
`204`		`- delete(s.updatedData, vID)`
`205`	`201`	`}`
`206`		`- return batch.Write()`
	`202`	`+ if err := batch.Write(); err != nil {`
	`203`	`+ return err`
	`204`	`+ }`
	`205`	`+ // we've successfully flushed the updates, clear the updated marker.`
	`206`	`+ clear(s.updatedData)`
	`207`	`+ return nil`
`207`	`208`	`}`
`208`	`209`
`209`	`210`	`// SetStatus sets the active status of the validator with the given vID`