Wrong assertion occurs when bulding acceleration structure

lifeisforu · baldurk · commit 3bd0721da858 · 2025-02-12T10:09:28.000Z
byteSize was already combined to dstoffset, so it must be tested using vbSize.
diff --git a/renderdoc/driver/d3d12/d3d12_manager.cpp b/renderdoc/driver/d3d12/d3d12_manager.cpp
@@ -2587,8 +2587,8 @@ ASBuildData *D3D12RTManager::CopyBuildInputs(
           unwrappedCmd->CopyBufferRegion(dstRes, dstOffset, Unwrap(sourceBuffer), srcOffs, vbSize);
 
           desc.Triangles.VertexBuffer.RVA = dstOffset - baseOffset;
-          RDCASSERT(desc.Triangles.VertexBuffer.RVA + byteSize <= allocedByteSize,
-                    desc.Triangles.VertexBuffer.RVA, byteSize, allocedByteSize);
+          RDCASSERT(desc.Triangles.VertexBuffer.RVA + vbSize <= allocedByteSize,
+                    desc.Triangles.VertexBuffer.RVA, vbSize, allocedByteSize);
 
           dstOffset = AlignUp16(dstOffset + vbSize);
         }

Original file line number	Diff line number	Diff line change
`@@ -2587,8 +2587,8 @@ ASBuildData *D3D12RTManager::CopyBuildInputs(`
`2587`	`2587`	`unwrappedCmd->CopyBufferRegion(dstRes, dstOffset, Unwrap(sourceBuffer), srcOffs, vbSize);`
`2588`	`2588`
`2589`	`2589`	`desc.Triangles.VertexBuffer.RVA = dstOffset - baseOffset;`
`2590`		`- RDCASSERT(desc.Triangles.VertexBuffer.RVA + byteSize <= allocedByteSize,`
`2591`		`- desc.Triangles.VertexBuffer.RVA, byteSize, allocedByteSize);`
	`2590`	`+ RDCASSERT(desc.Triangles.VertexBuffer.RVA + vbSize <= allocedByteSize,`
	`2591`	`+ desc.Triangles.VertexBuffer.RVA, vbSize, allocedByteSize);`
`2592`	`2592`
`2593`	`2593`	`dstOffset = AlignUp16(dstOffset + vbSize);`
`2594`	`2594`	`}`