Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping marginal notes #24

Open
brannondorsey opened this issue Aug 3, 2018 · 4 comments
Open

Overlapping marginal notes #24

brannondorsey opened this issue Aug 3, 2018 · 4 comments

Comments

@brannondorsey
Copy link
Member

screenshot from 2018-08-03 15-40-44

@nbriz
Copy link
Contributor

nbriz commented Aug 20, 2018

hmmmmm... what do u think we should do here? if we just push things down it could look weird if we have huge gaps between paragraphs to accommodate a marginal notes longer than the paragraph's content... my instinct is that if there's a huge marginal note, perhaps it should be part of the content && not a marginal note? or perhaps it needs to be smaller?

@brannondorsey
Copy link
Member Author

So the main reason we have a few of these larger marginal notes is because we made the decision to move the contents of several smaller and less developed secondary pages into marginal notes, and remove the original pages. Having larger marginal notes isn't ideal, but it is sort of inevitable given the solution we chose. Most of these types of marginal notes are too extraneous to be worked into the paragraphs themselves.

@nbriz
Copy link
Contributor

nbriz commented Aug 20, 2018

ok, but that's specifically an ML docs issue though, might make sense to discuss that there before making changes to BBElements

@brannondorsey
Copy link
Member Author

Ok, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants