Fix the lock to actually lock.

bzbarsky-apple · jtung-apple · web-flow · commit 0dd52354e585 · 2024-03-26T20:19:29.000-04:00
Co-authored-by: Jeff Tung &lt;100387939+jtung-apple@users.noreply.github.com&gt;
diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -1062,7 +1062,7 @@ - (void)_setupSubscription
     dispatch_after(dispatch_time(DISPATCH_TIME_NOW, static_cast<int64_t>(kSecondsToWaitBeforeMarkingUnreachableAfterSettingUpSubscription) * static_cast<int64_t>(NSEC_PER_SEC)), self.queue, ^{
         MTRDevice * strongSelf = weakSelf.strongObject;
         if (strongSelf != nil) {
-            std::lock_guard(strongSelf->_lock);
+            std::lock_guard lock(strongSelf->_lock);
             [strongSelf _markDeviceAsUnreachableIfNeverSubscribed];
         }
     });

Original file line number	Diff line number	Diff line change
`@@ -1062,7 +1062,7 @@ - (void)_setupSubscription`
`1062`	`1062`	`dispatch_after(dispatch_time(DISPATCH_TIME_NOW, static_cast<int64_t>(kSecondsToWaitBeforeMarkingUnreachableAfterSettingUpSubscription) * static_cast<int64_t>(NSEC_PER_SEC)), self.queue, ^{`
`1063`	`1063`	`MTRDevice * strongSelf = weakSelf.strongObject;`
`1064`	`1064`	`if (strongSelf != nil) {`
`1065`		`- std::lock_guard(strongSelf->_lock);`
	`1065`	`+ std::lock_guard lock(strongSelf->_lock);`
`1066`	`1066`	`[strongSelf _markDeviceAsUnreachableIfNeverSubscribed];`
`1067`	`1067`	`}`
`1068`	`1068`	`});`