Improve "need a custom toolchain" message to log more information.

bzbarsky-apple · bzbarsky-apple · commit 437782b064ed · 2024-02-21T11:03:12.000-05:00
Logging what gn thinks is going on for the host/target OS and cpu can help
diagnose why we didn't find toolchain in the big if cascade.
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
@@ -127,7 +127,9 @@ if (_chip_defaults.custom_toolchain != "") {
            "Unsupported target_cpu: ${current_cpu}. Shall be arm for webOS")
   }
 } else {
-  assert(false, "No toolchain specified, please specify custom_toolchain")
+  assert(
+      false,
+      "No toolchain specified, please specify custom_toolchain for host_os='${host_os}', target_os='${target_os}', host_cpu='${host_cpu}', target_cpu='${target_cpu}'")
 }
 
 set_default_toolchain(_default_toolchain)

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,9 @@ if (_chip_defaults.custom_toolchain != "") {`
`127`	`127`	`"Unsupported target_cpu: ${current_cpu}. Shall be arm for webOS")`
`128`	`128`	`}`
`129`	`129`	`} else {`
`130`		`- assert(false, "No toolchain specified, please specify custom_toolchain")`
	`130`	`+ assert(`
	`131`	`+ false,`
	`132`	`+ "No toolchain specified, please specify custom_toolchain for host_os='${host_os}', target_os='${target_os}', host_cpu='${host_cpu}', target_cpu='${target_cpu}'")`
`131`	`133`	`}`
`132`	`134`
`133`	`135`	`set_default_toolchain(_default_toolchain)`