Skip to content

Commit 4707e33

Browse files
Fix casing of command fields in Window Covering cluster.
Fixes project-chip#30306
1 parent 485b7dd commit 4707e33

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

src/app/tests/suites/certification/Test_TC_WNCV_4_1.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ tests:
7373
PICS: "WNCV.S.F00 && WNCV.S.C05.Rsp"
7474
arguments:
7575
values:
76-
- name: "liftPercent100thsValue"
76+
- name: "LiftPercent100thsValue"
7777
value: 2500
7878

7979
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
@@ -142,7 +142,7 @@ tests:
142142
PICS: WNCV.S.F00 && WNCV.S.C05.Rsp
143143
arguments:
144144
values:
145-
- name: "liftPercent100thsValue"
145+
- name: "LiftPercent100thsValue"
146146
value: 7520
147147

148148
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms

src/app/tests/suites/certification/Test_TC_WNCV_4_2.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ tests:
7373
PICS: WNCV.S.F01 && WNCV.S.C08.Rsp
7474
arguments:
7575
values:
76-
- name: "tiltPercent100thsValue"
76+
- name: "TiltPercent100thsValue"
7777
value: 3000
7878

7979
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms
@@ -142,7 +142,7 @@ tests:
142142
PICS: WNCV.S.F01 && WNCV.S.F04 && WNCV.S.C08.Rsp
143143
arguments:
144144
values:
145-
- name: "tiltPercent100thsValue"
145+
- name: "TiltPercent100thsValue"
146146
value: 6005
147147

148148
### Depends on a sleep/wait command how to do this with a real device for CI keep at 100ms

src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ tests:
7474
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
7575
arguments:
7676
values:
77-
- name: "liftPercent100thsValue"
77+
- name: "LiftPercent100thsValue"
7878
value: 0x3000
7979
response:
8080
error: CONSTRAINT_ERROR
@@ -86,7 +86,7 @@ tests:
8686
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
8787
arguments:
8888
values:
89-
- name: "liftPercent100thsValue"
89+
- name: "LiftPercent100thsValue"
9090
value: 10001
9191
response:
9292
error: CONSTRAINT_ERROR
@@ -98,7 +98,7 @@ tests:
9898
PICS: WNCV.S.F00 && WNCV.S.F02 || WNCV.S.F00 && WNCV.S.C05.Rsp
9999
arguments:
100100
values:
101-
- name: "liftPercent100thsValue"
101+
- name: "LiftPercent100thsValue"
102102
value: 0xFFFF
103103
response:
104104
error: CONSTRAINT_ERROR

src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ tests:
7474
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
7575
arguments:
7676
values:
77-
- name: "tiltPercent100thsValue"
77+
- name: "TiltPercent100thsValue"
7878
value: 0x3000
7979
response:
8080
error: CONSTRAINT_ERROR
@@ -86,7 +86,7 @@ tests:
8686
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
8787
arguments:
8888
values:
89-
- name: "tiltPercent100thsValue"
89+
- name: "TiltPercent100thsValue"
9090
value: 10001
9191
response:
9292
error: CONSTRAINT_ERROR
@@ -98,7 +98,7 @@ tests:
9898
PICS: WNCV.S.F01 && WNCV.S.F04 || WNCV.S.F01 && WNCV.S.C08.Rsp
9999
arguments:
100100
values:
101-
- name: "tiltPercent100thsValue"
101+
- name: "TiltPercent100thsValue"
102102
value: 0xFFFF
103103
response:
104104
error: CONSTRAINT_ERROR

src/app/tests/suites/certification/Test_TC_WNCV_4_5.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ tests:
4747
PICS: WNCV.S.F00 && WNCV.S.F02 && WNCV.S.C05.Rsp
4848
arguments:
4949
values:
50-
- name: "liftPercent100thsValue"
50+
- name: "LiftPercent100thsValue"
5151
value: 9000
5252

5353
#
@@ -83,7 +83,7 @@ tests:
8383
PICS: WNCV.S.F01 && WNCV.S.F04 && WNCV.S.C08.Rsp
8484
arguments:
8585
values:
86-
- name: "tiltPercent100thsValue"
86+
- name: "TiltPercent100thsValue"
8787
value: 9000
8888

8989
#

src/app/zap-templates/zcl/data-model/chip/window-covering.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -126,22 +126,22 @@ limitations under the License.
126126
<!-- Conformance feature [LF & ABS] - for now optional -->
127127
<command source="client" code="0x04" name="GoToLiftValue" optional="true" cli="zcl WindowCovering GoToLiftValue">
128128
<description>Go to lift value specified</description>
129-
<arg name="liftValue" type="int16u"/>
129+
<arg name="LiftValue" type="int16u"/>
130130
</command>
131131
<!-- Conformance feature LF & PA_LF | [LF] - for now optional -->
132132
<command source="client" code="0x05" name="GoToLiftPercentage" optional="true" cli="zcl WindowCovering GoToLiftPercentage">
133133
<description>Go to lift percentage specified</description>
134-
<arg name="liftPercent100thsValue" type="percent100ths"/>
134+
<arg name="LiftPercent100thsValue" type="percent100ths"/>
135135
</command>
136136
<!-- Conformance feature [TL & ABS] - for now optional -->
137137
<command source="client" code="0x07" name="GoToTiltValue" optional="true" cli="zcl WindowCovering GoToTiltValue">
138138
<description>Go to tilt value specified</description>
139-
<arg name="tiltValue" type="int16u"/>
139+
<arg name="TiltValue" type="int16u"/>
140140
</command>
141141
<!-- Conformance feature TL & PA_TL | [TL] - for now optional -->
142142
<command source="client" code="0x08" name="GoToTiltPercentage" optional="true" cli="zcl WindowCovering GoToTiltPercentage">
143143
<description>Go to tilt percentage specified</description>
144-
<arg name="tiltPercent100thsValue" type="percent100ths"/>
144+
<arg name="TiltPercent100thsValue" type="percent100ths"/>
145145
</command>
146146
</cluster>
147147

0 commit comments

Comments
 (0)