Address review comments.

Author: bzbarsky-apple

src/app/util/attribute-storage-null-handling.h

@@ -138,7 +138,7 @@ struct NumericAttributeTraits
 
         if (isNullable)
         {
-            // Smallest negative value is excluded for nullable types.
+            // Smallest negative value is excluded for nullable signed types.
             return static_cast<WorkingType>(std::numeric_limits<WorkingType>::min() + 1);
         }
 
@@ -154,7 +154,7 @@ struct NumericAttributeTraits
 
         if (isNullable)
         {
-            // Largest value is excluded for nullable types.
+            // Largest value is excluded for nullable unsigned types.
             return static_cast<WorkingType>(std::numeric_limits<WorkingType>::max() - 1);
         }
 

src/app/util/odd-sized-integers.h

@@ -221,7 +221,7 @@ struct NumericAttributeTraits<OddSizedInteger<ByteSize, IsSigned>, IsBigEndian>
         constexpr WorkingType signedMin = -(static_cast<WorkingType>(1) << (8 * ByteSize - 1));
         if (isNullable)
         {
-            // We have one fewer value.
+            // Smallest negative value is excluded for nullable signed types.
             return signedMin + 1;
         }
 
@@ -237,10 +237,10 @@ struct NumericAttributeTraits<OddSizedInteger<ByteSize, IsSigned>, IsBigEndian>
             return (static_cast<WorkingType>(1) << (8 * ByteSize - 1)) - 1;
         }
 
-        constexpr WorkingType unsignedMax = (static_cast<WorkingType>(1) << (8 * ByteSize));
+        constexpr WorkingType unsignedMax = (static_cast<WorkingType>(1) << (8 * ByteSize)) - 1;
         if (isNullable)
         {
-            // Largest value is excluded for nullable types.
+            // Largest value is excluded for nullable unsigned types.
             return unsignedMax - 1;
         }