bad comparison (project-chip#35763)

woody-apple · web-flow · commit ed5c819d624a · 2024-09-25T01:06:11.000Z
diff --git a/src/darwin/Framework/CHIP/MTRCertificates.mm b/src/darwin/Framework/CHIP/MTRCertificates.mm
@@ -186,7 +186,7 @@ + (BOOL)isCertificate:(MTRCertificateDERBytes)certificate1 equalTo:(MTRCertifica
         MTR_LOG_ERROR("Can't extract public key from second certificate: %s", ErrorStr(err));
         return NO;
     }
-    P256PublicKeySpan keySpan2(pubKey1.ConstBytes());
+    P256PublicKeySpan keySpan2(pubKey2.ConstBytes());
 
     if (!keySpan1.data_equal(keySpan2)) {
         return NO;

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ + (BOOL)isCertificate:(MTRCertificateDERBytes)certificate1 equalTo:(MTRCertifica`
`186`	`186`	`MTR_LOG_ERROR("Can't extract public key from second certificate: %s", ErrorStr(err));`
`187`	`187`	`return NO;`
`188`	`188`	`}`
`189`		`- P256PublicKeySpan keySpan2(pubKey1.ConstBytes());`
	`189`	`+ P256PublicKeySpan keySpan2(pubKey2.ConstBytes());`
`190`	`190`
`191`	`191`	`if (!keySpan1.data_equal(keySpan2)) {`
`192`	`192`	`return NO;`