move att-storage.h to src/app/util and make it known to GN (project-chip#32435)

* Move att-storage to be placed in util

* Restyle

* remove att storage from gn linter

Author: andy31415

.github/workflows/lint.yml

@@ -92,7 +92,6 @@ jobs:
                      --known-failure controller/ExamplePersistentStorage.h \
                      --known-failure app/AttributeAccessInterface.h \
                      --known-failure app/AttributeAccessToken.h \
-                     --known-failure app/att-storage.h \
                      --known-failure app/CommandHandler.h \
                      --known-failure app/CommandHandlerInterface.h \
                      --known-failure app/CommandSenderLegacyCallback.h \

examples/air-quality-sensor-app/linux/AirQualitySensorAppAttrUpdateDelegate.cpp

@@ -19,11 +19,11 @@
 #include "AirQualitySensorAppAttrUpdateDelegate.h"
 
 #include <app-common/zap-generated/attributes/Accessors.h>
-#include <app/att-storage.h>
 #include <app/clusters/general-diagnostics-server/general-diagnostics-server.h>
 #include <app/clusters/software-diagnostics-server/software-diagnostics-server.h>
 #include <app/clusters/switch-server/switch-server.h>
 #include <app/server/Server.h>
+#include <app/util/att-storage.h>
 #include <platform/PlatformManager.h>
 
 #include <air-quality-sensor-manager.h>

examples/all-clusters-app/linux/AllClustersCommandDelegate.cpp

@@ -19,12 +19,12 @@
 #include "AllClustersCommandDelegate.h"
 
 #include <app-common/zap-generated/attributes/Accessors.h>
-#include <app/att-storage.h>
 #include <app/clusters/general-diagnostics-server/general-diagnostics-server.h>
 #include <app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.h>
 #include <app/clusters/software-diagnostics-server/software-diagnostics-server.h>
 #include <app/clusters/switch-server/switch-server.h>
 #include <app/server/Server.h>
+#include <app/util/att-storage.h>
 #include <platform/PlatformManager.h>
 
 #include <air-quality-instance.h>

examples/all-clusters-app/linux/main-common.cpp

@@ -40,7 +40,6 @@
 #include <Options.h>
 #include <app-common/zap-generated/attributes/Accessors.h>
 #include <app/CommandHandler.h>
-#include <app/att-storage.h>
 #include <app/clusters/diagnostic-logs-server/diagnostic-logs-server.h>
 #include <app/clusters/identify-server/identify-server.h>
 #include <app/clusters/laundry-dryer-controls-server/laundry-dryer-controls-server.h>
@@ -50,6 +49,7 @@
 #include <app/clusters/valve-configuration-and-control-server/valve-configuration-and-control-server.h>
 #include <app/server/Server.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/attribute-storage.h>
 #include <lib/support/CHIPMem.h>
 #include <new>

examples/all-clusters-minimal-app/linux/main-common.cpp

@@ -19,10 +19,10 @@
 #include "include/tv-callbacks.h"
 #include <app-common/zap-generated/attributes/Accessors.h>
 #include <app/CommandHandler.h>
-#include <app/att-storage.h>
 #include <app/clusters/identify-server/identify-server.h>
 #include <app/server/Server.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <lib/support/CHIPMem.h>
 #include <new>
 #include <platform/PlatformManager.h>

examples/chef/esp32/main/main.cpp

@@ -40,9 +40,9 @@
 
 #include <app-common/zap-generated/callback.h>
 #include <app-common/zap-generated/cluster-objects.h>
-#include <app/att-storage.h>
 #include <app/server/Dnssd.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <setup_payload/QRCodeSetupPayloadGenerator.h>
 
 #include "Display.h"

examples/lighting-app/infineon/cyw30739/src/LightingManager.cpp

@@ -19,8 +19,8 @@
 
 #include "LightingManager.h"
 #include <app-common/zap-generated/attributes/Accessors.h>
-#include <app/att-storage.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <stdio.h>
 
 using namespace chip;

examples/lighting-app/linux/LightingAppCommandDelegate.cpp

@@ -19,11 +19,11 @@
 #include "LightingAppCommandDelegate.h"
 
 #include <app-common/zap-generated/attributes/Accessors.h>
-#include <app/att-storage.h>
 #include <app/clusters/general-diagnostics-server/general-diagnostics-server.h>
 #include <app/clusters/software-diagnostics-server/software-diagnostics-server.h>
 #include <app/clusters/switch-server/switch-server.h>
 #include <app/server/Server.h>
+#include <app/util/att-storage.h>
 #include <platform/PlatformManager.h>
 
 using namespace chip;

src/app/AttributePathExpandIterator.cpp

@@ -22,7 +22,7 @@
 #include <app/ConcreteAttributePath.h>
 #include <app/EventManagement.h>
 #include <app/GlobalAttributes.h>
-#include <app/att-storage.h>
+#include <app/util/att-storage.h>
 #include <lib/core/CHIPCore.h>
 #include <lib/core/TLVDebug.h>
 #include <lib/support/CodeUtils.h>

src/app/clusters/group-key-mgmt-server/group-key-mgmt-server.cpp

@@ -20,9 +20,9 @@
 #include <app/AttributeAccessInterface.h>
 #include <app/CommandHandler.h>
 #include <app/MessageDef/StatusIB.h>
-#include <app/att-storage.h>
 #include <app/server/Server.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/attribute-storage.h>
 #include <credentials/GroupDataProvider.h>
 #include <lib/support/CodeUtils.h>

src/app/clusters/groups-server/groups-server.cpp

@@ -21,9 +21,9 @@
 #include <app-common/zap-generated/cluster-objects.h>
 #include <app-common/zap-generated/ids/Clusters.h>
 #include <app/CommandHandler.h>
-#include <app/att-storage.h>
 #include <app/reporting/reporting.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/config.h>
 #include <credentials/GroupDataProvider.h>
 #include <inttypes.h>

src/app/clusters/mode-select-server/mode-select-server.cpp

@@ -22,9 +22,9 @@
 #include <app/AttributeAccessInterface.h>
 #include <app/CommandHandler.h>
 #include <app/ConcreteCommandPath.h>
-#include <app/att-storage.h>
 #include <app/clusters/mode-select-server/supported-modes-manager.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/attribute-storage.h>
 #include <app/util/config.h>
 #include <app/util/odd-sized-integers.h>

src/app/dynamic_server/DynamicDispatcher.cpp

@@ -30,8 +30,8 @@
 #include <app/MessageDef/AttributeReportIBs.h>
 #include <app/MessageDef/StatusIB.h>
 #include <app/WriteHandler.h>
-#include <app/att-storage.h>
 #include <app/data-model/Decode.h>
+#include <app/util/att-storage.h>
 #include <app/util/endpoint-config-api.h>
 #include <lib/core/CHIPError.h>
 #include <lib/core/DataModelTypes.h>

src/app/util/BUILD.gn

@@ -17,6 +17,7 @@ import("${chip_root}/src/app/common_flags.gni")
 
 source_set("types") {
   sources = [
+    "att-storage.h",
     "attribute-metadata.cpp",
     "attribute-metadata.h",
     "basic-types.h",

src/app/att-storage.h src/app/util/att-storage.h

@@ -25,7 +25,7 @@
 #include <app/util/endpoint-config-api.h>
 #include <lib/support/CodeUtils.h>
 
-#include <app/att-storage.h>
+#include <app/util/att-storage.h>
 #include <zap-generated/endpoint_config.h>
 
 #include <protocols/interaction_model/StatusCode.h>

src/app/util/attribute-storage.h

@@ -28,10 +28,10 @@
 #include <app/GlobalAttributes.h>
 #include <app/InteractionModelEngine.h>
 #include <app/RequiredPrivilege.h>
-#include <app/att-storage.h>
 #include <app/reporting/Engine.h>
 #include <app/reporting/reporting.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/attribute-storage-null-handling.h>
 #include <app/util/attribute-storage.h>
 #include <app/util/attribute-table.h>

src/app/util/ember-compatibility-functions.cpp

@@ -18,8 +18,8 @@
 
 #include <app/util/mock/MockNodeConfig.h>
 
-#include <app/att-storage.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <lib/support/CodeUtils.h>
 
 #include <utility>

src/app/util/mock/MockNodeConfig.cpp

@@ -33,8 +33,8 @@
 #include <app/MessageDef/AttributeDataIB.h>
 #include <app/MessageDef/AttributeReportIB.h>
 #include <app/MessageDef/AttributeStatusIB.h>
-#include <app/att-storage.h>
 #include <app/util/af.h>
+#include <app/util/att-storage.h>
 #include <app/util/mock/Constants.h>
 #include <app/util/mock/MockNodeConfig.h>
 

src/app/util/mock/attribute-storage.cpp

@@ -18,7 +18,7 @@
 #include <app-common/zap-generated/cluster-objects.h>
 #include <app/CommandHandler.h>
 #include <app/ConcreteCommandPath.h>
-#include <app/att-storage.h>
+#include <app/util/att-storage.h>
 
 #include <app/util/af-types.h>
 #include <app/util/privilege-storage.h>

src/darwin/Framework/CHIP/ServerEndpoint/MTRIMDispatch.mm

@@ -30,8 +30,8 @@
 // TODO: These af-types.h and att-storage.h and attribute-storage.h and
 // endpoint-config-api.h and probably CodeUtils.h bits are a hack that should
 // eventually go away.
-#include <app/att-storage.h>
 #include <app/util/af-types.h>
+#include <app/util/att-storage.h>
 #include <app/util/attribute-storage.h>
 #include <app/util/endpoint-config-api.h>
 #include <lib/support/CodeUtils.h>