Skip to content

Commit 7f86f69

Browse files
authored
fix: remove unused attribute columns for /insights/routing (#19059)
1 parent 93da9c5 commit 7f86f69

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

packages/app-store/routing-forms/lib/FieldTypes.ts

+12
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,18 @@ export const enum RoutingFormFieldType {
88
EMAIL = "email",
99
}
1010

11+
export const isValidRoutingFormFieldType = (type: string): type is RoutingFormFieldType => {
12+
return [
13+
RoutingFormFieldType.TEXT,
14+
RoutingFormFieldType.NUMBER,
15+
RoutingFormFieldType.TEXTAREA,
16+
RoutingFormFieldType.SINGLE_SELECT,
17+
RoutingFormFieldType.MULTI_SELECT,
18+
RoutingFormFieldType.PHONE,
19+
RoutingFormFieldType.EMAIL,
20+
].includes(type as RoutingFormFieldType);
21+
};
22+
1123
export const FieldTypes = [
1224
{
1325
label: "Short Text",

packages/features/insights/components/RoutingFormResponsesTable.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import classNames from "@calcom/lib/classNames";
2929
import { useCopy } from "@calcom/lib/hooks/useCopy";
3030
import { useLocale } from "@calcom/lib/hooks/useLocale";
3131
import { BookingStatus } from "@calcom/prisma/enums";
32-
import { RoutingFormFieldType } from "@calcom/routing-forms/lib/FieldTypes";
32+
import { RoutingFormFieldType, isValidRoutingFormFieldType } from "@calcom/routing-forms/lib/FieldTypes";
3333
import { trpc, type RouterOutputs } from "@calcom/trpc";
3434
import {
3535
Badge,
@@ -258,7 +258,7 @@ export function RoutingFormResponsesTable() {
258258
useInsightsParameters();
259259

260260
const {
261-
data: headers,
261+
data: headersRaw,
262262
isLoading: isHeadersLoading,
263263
isSuccess: isHeadersSuccess,
264264
} = trpc.viewer.insights.routingFormResponsesHeaders.useQuery({
@@ -268,6 +268,11 @@ export function RoutingFormResponsesTable() {
268268
routingFormId,
269269
});
270270

271+
const headers = useMemo(() => {
272+
if (!headersRaw) return;
273+
return headersRaw.filter((header) => header.label && isValidRoutingFormFieldType(header.type));
274+
}, [headersRaw]);
275+
271276
const { data: forms } = trpc.viewer.insights.getRoutingFormsForFilters.useQuery({
272277
userId,
273278
teamId,

0 commit comments

Comments
 (0)