fix: isChildEvent issue + loader is shown forever (#15524)

Author: emrysal

apps/web/modules/event-types/views/event-types-listing-view.tsx

@@ -863,14 +863,14 @@ const Main = ({
   const isMobile = useMediaQuery("(max-width: 768px)");
   const searchParams = useCompatSearchParams();
 
-  if (!rawData || status === "pending") {
-    return <SkeletonLoader />;
-  }
-
   if (status === "error") {
     return <Alert severity="error" title="Something went wrong" message={errorMessage} />;
   }
 
+  if (!rawData || status === "pending") {
+    return <SkeletonLoader />;
+  }
+
   const isFilteredByOnlyOneItem =
     (filters?.teamIds?.length === 1 || filters?.userIds?.length === 1) &&
     rawData.eventTypeGroups.length === 1;

packages/lib/event-types/getEventTypesByViewer.ts

@@ -134,9 +134,12 @@ export const getEventTypesByViewer = async (user: User, filters?: Filters, forRo
 
   const userEventTypes = (await Promise.all(profileEventTypes.map(mapEventType))).filter((eventType) => {
     const isAChildEvent = eventType.parentId;
+    if (!isAChildEvent) {
+      return true;
+    }
     // A child event only has one user
     const childEventAssignee = eventType.users[0];
-    if (isAChildEvent && childEventAssignee.id != user.id) {
+    if (!childEventAssignee || childEventAssignee.id != user.id) {
       return false;
     }
     return true;