From cbf9cc49ec83d78eb5e5cb1458ac45acc39a3881 Mon Sep 17 00:00:00 2001 From: hbjORbj Date: Thu, 16 Jan 2025 07:59:20 -0500 Subject: [PATCH] add helpful comments --- apps/web/server/lib/[user]/getServerSideProps.ts | 3 +++ packages/lib/defaultEvents.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/web/server/lib/[user]/getServerSideProps.ts b/apps/web/server/lib/[user]/getServerSideProps.ts index 0bacd5fec034c5..e9468f80a620eb 100644 --- a/apps/web/server/lib/[user]/getServerSideProps.ts +++ b/apps/web/server/lib/[user]/getServerSideProps.ts @@ -106,6 +106,9 @@ export const getServerSideProps: GetServerSideProps = async (cont if (isDynamicGroup) { const destinationUrl = `/${usernameList.join("+")}/dynamic`; + + // EXAMPLE - context.params: { orgSlug: 'acme', user: 'member0+owner1' } + // EXAMPLE - context.query: { redirect: 'undefined', orgRedirection: 'undefined', user: 'member0+owner1' } const originalQueryString = new URLSearchParams(context.query as Record).toString(); const destinationWithQuery = `${destinationUrl}?${originalQueryString}`; log.debug(`Dynamic group detected, redirecting to ${destinationUrl}`); diff --git a/packages/lib/defaultEvents.ts b/packages/lib/defaultEvents.ts index 81f7422252aa73..3799fc32f99172 100644 --- a/packages/lib/defaultEvents.ts +++ b/packages/lib/defaultEvents.ts @@ -178,7 +178,7 @@ export const getUsernameList = (users: string | string[] | undefined): string[] // So, even though this code handles even if individual user is dynamic link, that isn't a possibility right now. users = arrayCast(users); - const allUsers = users.map((user) => user.replace(/( |%20|%2b)/g, "+").split("+")).flat(); + const allUsers = users.map((user) => user.replace(/( |%20|%2B)/g, "+").split("+")).flat(); return Array.prototype.concat(...allUsers.map((userSlug) => slugify(userSlug))); };