fix: upgrade prismock to 1.33.4 (#17735)

* upgrade prismock, removed 2 hacks, update 3 tests

* yarnlock changes

Author: vijayraghav-io

package.json

@@ -105,7 +105,7 @@
     "node-gyp": "^10.2.0",
     "node-ical": "^0.16.1",
     "prettier": "^2.8.6",
-    "prismock": "^1.21.1",
+    "prismock": "^1.33.4",
     "resize-observer-polyfill": "^1.5.1",
     "tsc-absolute": "^1.0.0",
     "typescript": "^4.9.4",

packages/features/ee/workflows/lib/test/workflows.test.ts

@@ -443,7 +443,7 @@ describe("scheduleBookingReminders", () => {
     ];
 
     scheduledWorkflowReminders.forEach((reminder, index) => {
-      expect(expectedScheduledDates[index]).toStrictEqual(reminder.scheduledDate);
+      expect(expectedScheduledDates[index].toISOString()).toStrictEqual(reminder.scheduledDate.toISOString());
       expect(reminder.method).toBe(WorkflowMethods.EMAIL);
       if (index < 2) {
         expect(reminder.scheduled).toBe(true);
@@ -527,7 +527,7 @@ describe("scheduleBookingReminders", () => {
     ];
 
     scheduledWorkflowReminders.forEach((reminder, index) => {
-      expect(expectedScheduledDates[index]).toStrictEqual(reminder.scheduledDate);
+      expect(expectedScheduledDates[index].toISOString()).toStrictEqual(reminder.scheduledDate.toISOString());
       expect(reminder.method).toBe(WorkflowMethods.EMAIL);
       if (index < 2) {
         expect(reminder.scheduled).toBe(true);
@@ -662,7 +662,7 @@ describe("scheduleBookingReminders", () => {
     ];
 
     scheduledWorkflowReminders.forEach((reminder, index) => {
-      expect(expectedScheduledDates[index]).toStrictEqual(reminder.scheduledDate);
+      expect(expectedScheduledDates[index].toISOString()).toStrictEqual(reminder.scheduledDate.toISOString());
       expect(reminder.method).toBe(WorkflowMethods.SMS);
       if (index < 2) {
         expect(reminder.scheduled).toBe(true);

tests/libs/__mocks__/prisma.ts

@@ -12,37 +12,7 @@ vi.mock("@calcom/prisma", () => ({
 }));
 
 const handlePrismockBugs = () => {
-  const __updateBooking = prismock.booking.update;
-  const __findFirstOrThrowBooking = prismock.booking.findFirstOrThrow;
   const __findManyWebhook = prismock.webhook.findMany;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  prismock.booking.update = (...rest: any[]) => {
-    // There is a bug in prismock where it considers `createMany` and `create` itself to have the data directly
-    // In booking flows, we encounter such scenario, so let's fix that here directly till it's fixed in prismock
-    if (rest[0].data.references?.createMany) {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
-      rest[0].data.references.createMany = rest[0].data.references?.createMany.data;
-      logger.silly("Fixed Prismock bug");
-    }
-    if (rest[0].data.references?.create) {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
-      rest[0].data.references.create = rest[0].data.references?.create.data;
-      logger.silly("Fixed Prismock bug-1");
-    }
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    return __updateBooking(...rest);
-  };
-
-  prismock.booking.findFirstOrThrow = (...rest: any[]) => {
-    const { where } = rest[0];
-    delete where.NOT;
-    logger.silly("Fixed Prismock bug with using NOT in where clause");
-
-    return __findFirstOrThrowBooking(...rest);
-  };
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   prismock.webhook.findMany = (...rest: any[]) => {