Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Commit 8d77d54

Browse files
docs: update CardTransactionManager API
1 parent 48df81a commit 8d77d54

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88
### Changed
9+
- Added precision in the documentation of the methods of the `CardTransactionManager` API.
910
- UML diagrams moved to a dedicated repository (see `README.md` file).
1011

1112
## [1.4.0] - 2022-10-26

src/main/java/org/calypsonet/terminal/calypso/transaction/CardTransactionManager.java

+18-10
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,10 @@ CardTransactionManager prepareReadRecordsPartially(
563563
* #processClosing()}, the counter must have been read previously otherwise an {@link
564564
* IllegalStateException} will be raised during the execution of {@link #processClosing()}.
565565
*
566+
* <p>Note 3: if several counters of the same file have to be incremented at the same time of the
567+
* transaction, it is recommended to use the method {@link #prepareIncreaseCounters(byte, Map)}
568+
* for optimization reasons.
569+
*
566570
* @param sfi SFI of the EF to select.
567571
* @param counterNumber The number of the counter (must be zero in case of a simulated counter).
568572
* @param incValue Value to add to the counter (defined as a positive int {@code <=} 16777215
@@ -574,8 +578,10 @@ CardTransactionManager prepareReadRecordsPartially(
574578
CardTransactionManager prepareIncreaseCounter(byte sfi, int counterNumber, int incValue);
575579

576580
/**
577-
* Schedules the execution of a <b>Increase Multiple</b> command to increase multiple target
578-
* counters at the same time.
581+
* Schedules the execution of a <b>Increase Multiple</b> command or multiple <b>Increase</b>
582+
* commands to increase multiple target counters at the same time.
583+
*
584+
* <p>The decision to execute one or the other command is made according to the type of card.
579585
*
580586
* <p>Note 1: {@link CalypsoCard} is updated with the provided input data.
581587
*
@@ -587,8 +593,6 @@ CardTransactionManager prepareReadRecordsPartially(
587593
* @param counterNumberToIncValueMap The map containing the counter numbers to be incremented and
588594
* their associated increment values.
589595
* @return The current instance.
590-
* @throws UnsupportedOperationException If the increase multiple command is not available for
591-
* this card.
592596
* @throws IllegalArgumentException If one of the provided argument is out of range or if the map
593597
* is null or empty.
594598
* @since 1.1.0
@@ -605,6 +609,10 @@ CardTransactionManager prepareIncreaseCounters(
605609
* #processClosing()}, the counter must have been read previously otherwise an {@link
606610
* IllegalStateException} will be raised during the execution of {@link #processClosing()}.
607611
*
612+
* <p>Note 3: if several counters of the same file have to be decremented at the same time of the
613+
* transaction, it is recommended to use the method {@link #prepareDecreaseCounters(byte, Map)}
614+
* for optimization reasons.
615+
*
608616
* @param sfi SFI of the EF to select.
609617
* @param counterNumber The number of the counter (must be zero in case of a simulated counter).
610618
* @param decValue Value to subtract to the counter (defined as a positive int {@code <=} 16777215
@@ -616,8 +624,10 @@ CardTransactionManager prepareIncreaseCounters(
616624
CardTransactionManager prepareDecreaseCounter(byte sfi, int counterNumber, int decValue);
617625

618626
/**
619-
* Schedules the execution of a <b>Decrease Multiple</b> command to decrease multiple target
620-
* counters at the same time.
627+
* Schedules the execution of a <b>Decrease Multiple</b> command or multiple <b>Decrease</b>
628+
* commands to decrease multiple target counters at the same time.
629+
*
630+
* <p>The decision to execute one or the other command is made according to the type of card.
621631
*
622632
* <p>Note 1: {@link CalypsoCard} is updated with the provided input data.
623633
*
@@ -629,8 +639,6 @@ CardTransactionManager prepareIncreaseCounters(
629639
* @param counterNumberToDecValueMap The map containing the counter numbers to be decremented and
630640
* their associated decrement values.
631641
* @return The current instance.
632-
* @throws UnsupportedOperationException If the decrease multiple command is not available for
633-
* this card.
634642
* @throws IllegalArgumentException If one of the provided argument is out of range or if the map
635643
* is null or empty.
636644
* @since 1.1.0
@@ -833,7 +841,7 @@ CardTransactionManager prepareDecreaseCounters(
833841
* CalypsoCard#getSvDebitLogAllRecords()}.
834842
*
835843
* @return The current instance.
836-
* @throws UnsupportedOperationException If the application is not of type Stored Value.
844+
* @throws UnsupportedOperationException If the SV feature is not available for this card.
837845
* @since 1.0.0
838846
*/
839847
CardTransactionManager prepareSvReadAllLogs();
@@ -941,7 +949,7 @@ CardTransactionManager prepareDecreaseCounters(
941949
*
942950
* @param pin The PIN code value (4-byte long byte array).
943951
* @return The current instance.
944-
* @throws UnsupportedOperationException If the PIN feature is not available for this card
952+
* @throws UnsupportedOperationException If the PIN feature is not available for this card.
945953
* @throws IllegalArgumentException If the provided argument is out of range.
946954
* @throws IllegalStateException If commands have been prepared before invoking this process
947955
* method.

0 commit comments

Comments
 (0)