Skip to content

Commit 2fd97a2

Browse files
committed
TC-CC-3.2: Change timing so range tolerance doesn't span wrap
This lets us omit the manual step. Manual steps in the middle of a timed test will never work. Also fix the tolerance calculation.
1 parent e96ddd9 commit 2fd97a2

File tree

1 file changed

+18
-31
lines changed

1 file changed

+18
-31
lines changed

src/app/tests/suites/certification/Test_TC_CC_3_2.yaml

+18-31
Original file line numberDiff line numberDiff line change
@@ -86,58 +86,45 @@ tests:
8686
- name: "OptionsOverride"
8787
value: 0
8888

89-
- label: "Wait 10s"
89+
- label: "Wait 5s"
9090
PICS: CC.S.F00
9191
cluster: "DelayCommands"
9292
command: "WaitForMs"
9393
arguments:
9494
values:
9595
- name: "ms"
96-
value: 10000
96+
value: 5000
9797

98-
#Tolerance to be computed from the range
99-
#Start value 200, expected value 250, 200 - 250 = -50, 50 % 15 = 8 , So 250+/-8 We need two range here as 254 is the max value
100-
#242...254...0...4
101-
#Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197
102-
- label: "Step 2c: TH reads CurrentHue attribute from DUT"
103-
PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
104-
verification: |
105-
./chip-tool colorcontrol read current-hue 1 1
106-
107-
After 10 seconds, Verify that CurrentHue attribute value is 250 On TH(chip-tool) Logs and below is the sample log provided for the raspi platform
108-
109-
[1649662328.012887][8447:8452] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087279986
110-
[1649662328.012957][8447:8452] CHIP:TOO: Current hue: 250
111-
[1649662328.013055][8447:8452] CHIP:EM: Sending Standalone Ack for MessageCounter:8634142 on exchange 13871i
112-
(Value can vary)
113-
cluster: "LogCommands"
114-
command: "UserPrompt"
115-
arguments:
116-
values:
117-
- name: "message"
118-
value: "Enter 'y' after success"
119-
- name: "expectedValue"
120-
value: "y"
98+
#Tolerance to be computed from the range (note)
99+
# In 5 seconds, the value will have changed by 25. A 15% tolerance is 1.7, so ~2, and value must be 225 +/- 2
100+
- label: "Step 2d: TH reads CurrentHue attribute from DUT"
101+
PICS: CC.S.F00 && CC.S.A0000
102+
command: "readAttribute"
103+
attribute: "CurrentHue"
104+
response:
105+
constraints:
106+
minValue: 223
107+
maxValue: 227
121108

122-
- label: "Wait 10s"
109+
- label: "Wait 15s"
123110
PICS: CC.S.F00
124111
cluster: "DelayCommands"
125112
command: "WaitForMs"
126113
arguments:
127114
values:
128115
- name: "ms"
129-
value: 10000
116+
value: 15000
130117

131-
#Tolerance to be computed from the range
132-
#Start value 200, expected value 45, 200 - 45 = 155, 155 % 15 = 23 , So 45+/-23
118+
# Tolerance to be computed from the range, hue wraps back to 0 the continues
119+
# In 20s the value will have changed by 100 and wrapped around to 45. A 15% tolerance is 15, so 30 to 60
133120
- label: "Step 2d: TH reads CurrentHue attribute from DUT"
134121
PICS: CC.S.F00 && CC.S.A0000
135122
command: "readAttribute"
136123
attribute: "CurrentHue"
137124
response:
138125
constraints:
139-
minValue: 22
140-
maxValue: 68
126+
minValue: 30
127+
maxValue: 60
141128

142129
- label: "Wait 10s"
143130
PICS: CC.S.F00

0 commit comments

Comments
 (0)