Skip to content

Commit 8582eac

Browse files
committed
Address review comments, fix
1 parent 7232fe5 commit 8582eac

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/python_testing/TC_RR_1_1.py

+5-7
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import math
2121
import queue
2222
import random
23+
import string
2324
import time
2425
from typing import Any, Dict, List, Set
2526

@@ -37,7 +38,7 @@
3738

3839

3940
def generate_controller_name(fabric_index: int, controller_index: int):
40-
return f"RD{fabric_index}{string.ascii_uppercase[controller_index]))}"
41+
return f"RD{fabric_index}{string.ascii_uppercase[controller_index]}"
4142

4243

4344
class TC_RR_1_1(MatterBaseTest):
@@ -225,8 +226,7 @@ async def test_TC_RR_1_1(self):
225226
logging.info("Step 2: Setting the Label field for each fabric and BasicInformation.NodeLabel to 32 characters")
226227

227228
for fabric in fabric_table:
228-
# Client is client A for each fabric to set the Label field
229-
client_name = "RD%dA" % fabric.fabricIndex
229+
client_name = generate_controller_name(fabric.fabricIndex, 0)
230230
client = client_by_name[client_name]
231231

232232
# Send the UpdateLabel command
@@ -451,8 +451,7 @@ async def test_TC_RR_1_1(self):
451451
fabric_unique_clients: List[Any] = []
452452

453453
for fabric in fabric_table:
454-
# Client is client A for each fabric
455-
client_name = "RD%dA" % fabric.fabricIndex
454+
client_name = generate_controller_name(fabric.fabricIndex, 0)
456455
fabric_unique_clients.append(client_by_name[client_name])
457456

458457
# Step 13: Write and verify indicated_max_group_keys_per_fabric group keys to all fabrics.
@@ -695,8 +694,7 @@ async def send_acl(self,
695694
fabric_table: List[
696695
Clusters.OperationalCredentials.Structs.FabricDescriptorStruct]):
697696
for fabric in fabric_table:
698-
# Client is client A for each fabric
699-
client_name = "RD%dA" % fabric.fabricIndex
697+
client_name = generate_controller_name(fabric.fabricIndex, 0)
700698
client = client_by_name[client_name]
701699

702700
acl = self.build_acl(enable_access_to_group_cluster)

0 commit comments

Comments
 (0)