Skip to content

Commit 9eaec67

Browse files
committed
Allow gating self-selecting tests on PICS
1 parent 9113441 commit 9eaec67

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/python_testing/matter_testing_support.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -2171,8 +2171,9 @@ def run_if_endpoint_matches(accept_function: EndpointCheckFunction):
21712171
"""
21722172
def run_if_endpoint_matches_internal(body):
21732173
def per_endpoint_runner(self: MatterBaseTest, *args, **kwargs):
2174-
asserts.assert_false(self.get_test_pics(self.current_test_info.name),
2175-
"pics_ method supplied for run_if_endpoint_matches.")
2174+
# Disabling this for now so the TH does not need to spend the time to run these tests. We can PICS-gate these and re-evaluate in 1.5
2175+
# asserts.assert_false(self.get_test_pics(self.current_test_info.name),
2176+
# "pics_ method supplied for run_if_endpoint_matches.")
21762177
runner_with_timeout = asyncio.wait_for(should_run_test_on_endpoint(self, accept_function), timeout=60)
21772178
should_run_test = asyncio.run(runner_with_timeout)
21782179
if not should_run_test:

src/python_testing/test_testing/TestDecorators.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,12 @@ def main():
253253
if not ok:
254254
failures.append("Test case failure: test_endpoints")
255255

256-
test_name = 'test_endpoint_with_pics'
257-
test_runner.set_test('TestDecorators.py', 'TestDecorators', test_name)
258-
ok = test_runner.run_test_with_mock_read(read_resp, hooks)
259-
if ok:
260-
failures.append(f"Did not get expected test assertion on {test_name}")
256+
# Disabling this for now - in 1.4 we will allow self-selecting tests that are also gated by PICS
257+
# test_name = 'test_endpoint_with_pics'
258+
# test_runner.set_test('TestDecorators.py', 'TestDecorators', test_name)
259+
# ok = test_runner.run_test_with_mock_read(read_resp, hooks)
260+
# if ok:
261+
# failures.append(f"Did not get expected test assertion on {test_name}")
261262

262263
# Test should run once for the whole node, regardless of the number of endpoints
263264
def run_check(test_name: str, read_response: Attribute.AsyncReadTransaction.ReadResponse, expect_skip: bool) -> None:

0 commit comments

Comments
 (0)