Skip to content

Commit 9ebe3d5

Browse files
committed
Add comment
1 parent 3e3cfed commit 9ebe3d5

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/python_testing/TC_pics_checker.py

+5
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,11 @@ def test_TC_IDM_10_4(self):
164164
except ValueError:
165165
location = FeaturePathLocation(endpoint_id=self.endpoint_id,
166166
cluster_id=cluster_id, feature_code=str(feature_mask))
167+
# The feature_mask is from the code generated feature masks, not the features as listed on the
168+
# device. If we get an error here, this is a problem with the codegen or spec, not with the device
169+
# under test. We still want the problem recorded, but this does not indicate a problem on the DUT.
170+
# There are two clusters with known bad features here - RvcRunMode and RvcCleanMode both have a
171+
# feature mask of kNoFeatures and an empty "mask" of 0x0.
167172
self.record_warning("PICS check", location=location,
168173
problem=f"Unable to parse feature mask {feature_mask} from cluster {cluster}")
169174
continue

0 commit comments

Comments
 (0)