@@ -30,8 +30,8 @@ The ClusterServerClass is a **Very** light wrapper over ClusterLogic. It
30
30
translates Interaction Model wire format handling into API calls for cluster
31
31
logic methods.
32
32
33
- This class iImplements both the AttributeAccessInterface and the CommandHandler
34
- interfaces so ClusterLogic properly handles data dependencies between command
33
+ This class implements both the AttributeAccessInterface and the CommandHandler
34
+ interfaces so ClusterLogic properly handles data dependencies between commands
35
35
and attributes.
36
36
37
37
An example code snippet showing the translation of the TLV into API calls to the
@@ -60,9 +60,9 @@ CHIP_ERROR DiscoBallServer::Read(const ConcreteReadAttributePath & aPath,
60
60
The ClusterLogic class is for all the code that is SHARED between platforms. It
61
61
does NOT include any TLV parsing or direct calls to Ember/IM/LogEvent etc.
62
62
63
- The class should include attribute getter /setters and handlers for all commands.
63
+ The class should include attribute getters /setters and handlers for all commands.
64
64
65
- The class receive “plain data” Matter requests from ClusterServer class,
65
+ The class receives “plain data” Matter requests from ClusterServer class,
66
66
performs required common actions, and calls driver class to perform platform- or
67
67
hardware-specific actions. It also receives driver updates (e.g.
68
68
application-driven value changes) from the ClusterDriver class and updates state
@@ -108,9 +108,9 @@ The ClusterDriver is called by the ClusterLogic class and is used to translate
108
108
attribute changes and commands into application actions. It also reports
109
109
external changes back to the ClusterLogic class.
110
110
111
- The API design for this class with vary by the cluster, but it si generally
111
+ The API design for this class will vary by the cluster, but it is generally
112
112
recommended to use a generic API where possible, so the API ports easily to
113
- other platforms. For example an attribute changed callback with the changes
113
+ other platforms, for example an attribute changed callback with the changes
114
114
listed. It is important to be careful about the design and revisit this early if
115
115
issues arise.
116
116
@@ -150,7 +150,7 @@ Important tests to consider:
150
150
- Correctness can mostly be validated by inspection if it’s trivial.
151
151
- Important tests
152
152
- Errors when ClusterLogic instances aren’t properly registered.
153
- - Flow through to ClusterLogic for all reads/writes/command .
153
+ - Flow through to ClusterLogic for all reads/writes/commands .
154
154
- Can unit test this class by generating the TLV / path for input, parsing the
155
155
TLV output.
156
156
0 commit comments