Skip to content

Commit c197ec6

Browse files
committed
address review comments
1 parent eb18b1f commit c197ec6

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/python_testing/matter_testing_support.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -1001,20 +1001,21 @@ def skip_step(self, step):
10011001
self.step(step)
10021002
self.mark_current_step_skipped()
10031003

1004-
def skip_all_remaining_steps(self, starting_step):
1004+
def skip_all_remaining_steps(self, starting_step_number):
10051005
''' Skips all remaining test steps starting with provided starting step
10061006
1007-
starting_step must be provided, and is not derived intentionally. By providing argument
1007+
starting_step_number gives the first step to be skipped, as definted in the TestStep.test_plan_number
1008+
starting_step_number must be provided, and is not derived intentionally. By providing argument
10081009
test is more deliberately identifying where test skips are starting from, making
10091010
it easier to validate against the test plan for correctness.
10101011
'''
10111012
steps = self.get_test_steps(self.current_test_info.name)
10121013
for idx, step in enumerate(steps):
1013-
if step.test_plan_number == starting_step:
1014+
if step.test_plan_number == starting_step_number:
10141015
starting_step_idx = idx
10151016
break
10161017
else:
1017-
raise TestingExpection("skip_all_remaining_steps was provided with invalid starting_step_num")
1018+
asserts.fail("skip_all_remaining_steps was provided with invalid starting_step_num")
10181019
remaining = steps[starting_step_idx:]
10191020
for step in remaining:
10201021
self.skip_step(step.test_plan_number)

0 commit comments

Comments
 (0)