Skip to content

Commit ccffd58

Browse files
committed
DM XMLs: rename in-progress directory to 1.4
Also flip the default in the spec parsing to use 1.4
1 parent da6df48 commit ccffd58

File tree

196 files changed

+16
-16
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

196 files changed

+16
-16
lines changed
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/python_testing/TestSpecParsingSupport.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -259,21 +259,21 @@ def test_build_xml_override(self):
259259
# checks that the 1.3 spec (default) does not contain in-progress clusters and the TOT does
260260
tot_xml_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.kMaster)
261261
one_three_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.k1_3)
262-
in_progress, problems = build_xml_clusters(PrebuiltDataModelDirectory.kInProgress)
262+
one_four_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.k1_4)
263263
asserts.assert_greater(len(set(tot_xml_clusters.keys()) - set(one_three_clusters.keys())),
264264
0, "Master dir does not contain any clusters not in 1.3")
265-
asserts.assert_greater(len(set(tot_xml_clusters.keys()) - set(in_progress.keys())),
266-
0, "Master dir does not contain any clusters not in in_progress")
267-
asserts.assert_greater(len(set(in_progress.keys()) - set(one_three_clusters.keys())),
268-
0, "in_progress dir does not contain any clusters not in 1.3")
265+
asserts.assert_greater(len(set(tot_xml_clusters.keys()) - set(one_four_clusters.keys())),
266+
0, "Master dir does not contain any clusters not in 1.4")
267+
asserts.assert_greater(len(set(one_four_clusters.keys()) - set(one_three_clusters.keys())),
268+
0, "1.4 dir does not contain any clusters not in 1.3")
269269
# only the pulse width modulation cluster was removed post 1.3
270270
asserts.assert_equal(set(one_three_clusters.keys()) - set(tot_xml_clusters.keys()),
271271
set([Clusters.PulseWidthModulation.id]), "There are some 1.3 clusters that are not included in the TOT spec")
272-
asserts.assert_equal(set(in_progress.keys())-set(tot_xml_clusters.keys()),
273-
set(), "There are some in_progress clusters that are not included in the TOT spec")
272+
asserts.assert_equal(set(one_four_clusters.keys())-set(tot_xml_clusters.keys()),
273+
set(), "There are some 1.4 clusters that are not included in the TOT spec")
274274

275275
str_path = str(os.path.join(os.path.dirname(os.path.realpath(__file__)),
276-
'..', '..', 'data_model', 'in_progress', 'clusters'))
276+
'..', '..', 'data_model', '1.4', 'clusters'))
277277
string_override_check, problems = build_xml_clusters(str_path)
278278
asserts.assert_equal(string_override_check.keys(), self.spec_xml_clusters.keys(), "Mismatched cluster generation")
279279

@@ -466,18 +466,18 @@ def test_provisional_clusters(self):
466466
def test_atomic_thermostat(self):
467467
tot_xml_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.kMaster)
468468
one_three_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.k1_3)
469-
in_progress, problems = build_xml_clusters(PrebuiltDataModelDirectory.kInProgress)
469+
one_four_clusters, problems = build_xml_clusters(PrebuiltDataModelDirectory.k1_4)
470470

471471
asserts.assert_in("Atomic Request", tot_xml_clusters[Clusters.Thermostat.id].command_map,
472472
"Atomic request not found on thermostat command map")
473473
request_id = tot_xml_clusters[Clusters.Thermostat.id].command_map["Atomic Request"]
474474
asserts.assert_in(request_id, tot_xml_clusters[Clusters.Thermostat.id].accepted_commands.keys(),
475475
"Atomic request not found in thermostat accepted command list")
476476

477-
asserts.assert_in("Atomic Response", tot_xml_clusters[Clusters.Thermostat.id].command_map,
477+
asserts.assert_in("Atomic Response", one_four_clusters[Clusters.Thermostat.id].command_map,
478478
"Atomic response not found in the thermostat command map")
479479
response_id = tot_xml_clusters[Clusters.Thermostat.id].command_map["Atomic Response"]
480-
asserts.assert_in(response_id, tot_xml_clusters[Clusters.Thermostat.id].generated_commands.keys(),
480+
asserts.assert_in(response_id, one_four_clusters[Clusters.Thermostat.id].generated_commands.keys(),
481481
"Atomic response not found in thermostat generated command list")
482482

483483
asserts.assert_not_in(

src/python_testing/spec_parsing_support.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ def check_clusters_for_unknown_commands(clusters: dict[int, XmlCluster], problem
509509

510510
class PrebuiltDataModelDirectory(Enum):
511511
k1_3 = auto()
512-
kInProgress = auto()
512+
k1_4 = auto()
513513
kMaster = auto()
514514

515515

@@ -521,15 +521,15 @@ class DataModelLevel(str, Enum):
521521
def _get_data_model_directory(data_model_directory: typing.Union[PrebuiltDataModelDirectory, str], data_model_level: DataModelLevel) -> str:
522522
if data_model_directory == PrebuiltDataModelDirectory.k1_3:
523523
return os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..', 'data_model', '1.3', data_model_level)
524-
elif data_model_directory == PrebuiltDataModelDirectory.kInProgress:
525-
return os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..', 'data_model', 'in_progress', data_model_level)
524+
elif data_model_directory == PrebuiltDataModelDirectory.k1_4:
525+
return os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..', 'data_model', '1.4', data_model_level)
526526
elif data_model_directory == PrebuiltDataModelDirectory.kMaster:
527527
return os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..', 'data_model', 'master', data_model_level)
528528
else:
529529
return data_model_directory
530530

531531

532-
def build_xml_clusters(data_model_directory: typing.Union[PrebuiltDataModelDirectory, str] = PrebuiltDataModelDirectory.kInProgress) -> tuple[dict[uint, XmlCluster], list[ProblemNotice]]:
532+
def build_xml_clusters(data_model_directory: typing.Union[PrebuiltDataModelDirectory, str] = PrebuiltDataModelDirectory.k1_4) -> tuple[dict[uint, XmlCluster], list[ProblemNotice]]:
533533
dir = _get_data_model_directory(data_model_directory, DataModelLevel.kCluster)
534534

535535
clusters: dict[int, XmlCluster] = {}
@@ -776,7 +776,7 @@ def parse_single_device_type(root: ElementTree.Element) -> tuple[list[ProblemNot
776776
return device_types, problems
777777

778778

779-
def build_xml_device_types(data_model_directory: typing.Union[PrebuiltDataModelDirectory, str] = PrebuiltDataModelDirectory.kInProgress) -> tuple[dict[int, XmlDeviceType], list[ProblemNotice]]:
779+
def build_xml_device_types(data_model_directory: typing.Union[PrebuiltDataModelDirectory, str] = PrebuiltDataModelDirectory.k1_4) -> tuple[dict[int, XmlDeviceType], list[ProblemNotice]]:
780780
dir = _get_data_model_directory(data_model_directory, DataModelLevel.kDeviceType)
781781
device_types: dict[int, XmlDeviceType] = {}
782782
problems = []

0 commit comments

Comments
 (0)