fix: error on illegal page size (#662)

* fix: error on illegal page size

* `poetry black`

Co-authored-by: Thomas Harning Jr <thomas@censys.io>

* move arg checking before saved query

* flake8

* chore(deps) poetry update and dev dependency update

* fix(tests) add tests for page size handling

* chore(black) fix trailing comma

---------

Co-authored-by: Andrew Alexander <andrewalexander@censys.io>
Co-authored-by: Thomas Harning Jr <thomas@censys.io>
Co-authored-by: Andrew Alexander <andrewalexander@censys.com>

Author: 4 people

censys/cli/commands/asm.py

@@ -547,6 +547,13 @@ def cli_execute_saved_query_by_name(args: argparse.Namespace):
     Args:
         args (Namespace): Argparse Namespace.
     """
+    # do some sanity checking on page size before anything else
+    if args.page_size > 1000:
+        console.print(
+            "page size must be within [0,1000]. To fetch all pages, specify --pages -1 with any legal page size"
+        )
+
+        sys.exit(1)
     s = InventorySearch(args.api_key)
     q = SavedQueries(args.api_key)
     # get query from name
@@ -573,6 +580,13 @@ def cli_execute_saved_query_by_id(args: argparse.Namespace):
     Args:
         args (Namespace): Argparse Namespace.
     """
+    # do some sanity checking on page size before anything else
+    if args.page_size > 1000:
+        console.print(
+            "page size must be within [0,1000]. To fetch all pages, specify --pages -1 with any legal page size"
+        )
+
+        sys.exit(1)
     s = InventorySearch(args.api_key)
     q = SavedQueries(args.api_key)
     try:

docs/requirements.txt

@@ -1,6 +1,6 @@
 sphinx==7.2.6
 sphinxcontrib-autoprogram==0.1.9
-sphinx-rtd-theme==1.3.0
+sphinx-rtd-theme==3.0.2
 sphinx-prompt==1.8.0
 sphinx-tabs==3.4.1
 sphinx-copybutton==0.5.2