Skip to content

Commit fa1432a

Browse files
Fix issue #120 and push to Bioc
1 parent 7f85aba commit fa1432a

23 files changed

+112
-6
lines changed

DESCRIPTION

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: CAGEr
22
Title: Analysis of CAGE (Cap Analysis of Gene Expression) sequencing data for precise mapping of transcription start sites and promoterome mining
3-
Version: 2.11.3
4-
Date: 2024-05-24
3+
Version: 2.11.4
4+
Date: 2024-08-02
55
Authors@R:
66
c( person("Vanja", "Haberle", email = "vanja.haberle@gmail.com", role = "aut"),
77
person("Charles", "Plessy", email = "charles.plessy@oist.jp", role = "cre"),

NAMESPACE

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export(distclu)
4040
export(exportToTrack)
4141
export(expressionClasses)
4242
export(filterLowExpCTSS)
43+
export(filteredCTSSidx)
4344
export(findStrandInvaders)
4445
export(flagByUpstreamSequences)
4546
export(flagLowExpCTSS)

NEWS.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Upcoming changes in version 2.11.4
1+
# Changes in version 2.11.4
22

33
BACKWARDS-INCOMPATIBLE CHANGES
44

@@ -8,6 +8,11 @@ NEW FEATURES
88

99
- Support the use of `TxDB` objects for annotating clusters.
1010

11+
BUG FIXES
12+
13+
- Fix issue #120 introduced in 2.11.3, where clustering functions would
14+
fail if `filterLowExpCTSS` was not run before.
15+
1116
# Changes in version 2.11.3
1217

1318
BACKWARDS-INCOMPATIBLE CHANGES

R/CAGEr.R

+2
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,8 @@ setMethod("validSamples", "CAGEr", function (object, x){
182182
#'
183183
#' @export
184184
#'
185+
#' @family CAGEr filter functions
186+
#'
185187
#' @examples
186188
#' flagLowExpCTSS(exampleCAGEexp, threshold = 100, nrPassThreshold = 2)
187189

R/GetMethods.R

+22-3
Original file line numberDiff line numberDiff line change
@@ -454,13 +454,32 @@ setMethod( "tagClustersGR", "CAGEexp"
454454
.TagClusters(tc)
455455
})
456456

457-
#' @name filteredCTSSidx
458-
#' @noRd
457+
#' The `filteredCTSSidx()` function is in _CAGEr_ functions to retrieve the
458+
#' result of the `flagLowExpCTSS()` function in a safe way.
459+
#'
460+
#' @returns Returns the value of `filteredCTSSidx` in the row ranges of the
461+
#' tag count matrix experiment of the `CAGEexp` object, or `Rle(TRUE)` if it
462+
#' was `NULL`
463+
#'
464+
#' @param object A [`CAGEexp`] object
465+
#'
466+
#' @export
467+
#'
468+
#' @examples
469+
#'
470+
#' filteredCTSSidx(exampleCAGEexp)
471+
#'
472+
#' @family CAGEr filter functions
473+
#' @family CAGEr accessor methods
459474

460475
setGeneric("filteredCTSSidx", function(object) standardGeneric("filteredCTSSidx"))
461476

477+
#' @rdname filteredCTSSidx
478+
462479
setMethod("filteredCTSSidx", "CAGEexp", function (object){
463-
rowData(CTSStagCountSE(object))$filteredCTSSidx
480+
res <- rowData(CTSStagCountSE(object))$filteredCTSSidx
481+
if (is.null(res)) return(Rle(TRUE))
482+
res
464483
})
465484

466485

man/CTSScoordinates.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/CTSScumulativesTagClusters.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/CTSSnormalizedTpm.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/CTSStagCount.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/GeneExpDESeq2.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/GeneExpSE.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/consensusClusters.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/expressionClasses.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/filteredCTSSidx.Rd

+53
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/flagByUpstreamSequences.Rd

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/flagLowExpCTSS.Rd

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/genomeName.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/inputFiles.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/inputFilesType.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/librarySizes.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/sampleLabels.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/seqNameTotalsSE.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/tagClusters.Rd

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)