Skip to content

Commit 25d1559

Browse files
authored
release-note.sh fixes (shader-slang#5068)
Add a gh.exe search path that works with cygwin installations. Do not bail out from the breaking changes loop when a change is found without PR#. Instead, continue to the next one. This fixes an issue where [BREAKING] changes appear in the detailed change list by not in the summary of breaking changes.
1 parent d866c0b commit 25d1559

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/scripts/release-note.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ verbose=true
1616
$verbose && echo "Reminder: PLEASE make sure your local repo is up-to-date before running the script." >&2
1717

1818
gh=""
19-
for candidate in "$(which gh.exe)" "/mnt/c/Program Files/GitHub CLI/gh.exe" "/c/Program Files/GitHub CLI/gh.exe"
19+
for candidate in "$(which gh.exe)" "/mnt/c/Program Files/GitHub CLI/gh.exe" "/c/Program Files/GitHub CLI/gh.exe" "/cygdrive/c/Program Files/GitHub CLI/gh.exe"
2020
do
2121
if [ -x "$candidate" ]
2222
then
@@ -51,7 +51,7 @@ do
5151

5252
# Get PR number from the git commit title
5353
pr="$(echo "$line" | grep '#[1-9][0-9][0-9][0-9][0-9]*' | sed 's|.* (\#\([1-9][0-9][0-9][0-9][0-9]*\))|\1|')"
54-
[ "x$pr" = "x" ] && break
54+
[ "x$pr" = "x" ] && continue
5555

5656
# Check if the PR is marked as a breaking change
5757
if "$gh" issue view $pr --json labels | grep -q 'pr: breaking change'

0 commit comments

Comments
 (0)