Skip to content

Commit f0431b8

Browse files
authored
CI: Build the full slang-wasm.[js|wasm] targets instead of just the slang library. (shader-slang#5998)
A recent build breakage for slang-wasm.[js|wasm] was not noticed by CI since it built the slang library target instead of the slang-wasm.js "executable" target. (We added a that used objcopy to split debug info from executables. objcopy does not report errors when it finds object files with unexpected format inside static libraries, but it *does* report errors when it's run on an exceutable of unexpected format, such as in the case of slang-wasm.js.) This closes shader-slang#5959.
1 parent 00e7542 commit f0431b8

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/ci.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,9 @@ jobs:
125125
mkdir generators
126126
cmake --install build --prefix generators --component generators
127127
emcmake cmake -DSLANG_GENERATORS_PATH=generators/bin --preset emscripten -DSLANG_SLANG_LLVM_FLAVOR=DISABLE
128-
cmake --build --preset emscripten --config "$cmake_config" --target slang
129-
[ -f "build.em/$cmake_config/lib/libslang.a" ]
130-
[ -f "build.em/$cmake_config/lib/libcompiler-core.a" ]
131-
[ -f "build.em/$cmake_config/lib/libcore.a" ]
128+
cmake --build --preset emscripten --config "$cmake_config" --target slang-wasm
129+
[ -f "build.em/$cmake_config/bin/slang-wasm.wasm" ]
130+
[ -f "build.em/$cmake_config/bin/slang-wasm.js" ]
132131
else
133132
if [[ "${{ matrix.os }}" =~ "windows" && "${{ matrix.config }}" != "release" && "${{ matrix.config }}" != "releaseWithDebugInfo" ]]; then
134133
# Doing a debug build will try to link against a release built llvm, this

0 commit comments

Comments
 (0)