Skip to content

Clean up the public interface #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bifurcation opened this issue Apr 21, 2025 · 0 comments · Fixed by #60
Closed

Clean up the public interface #51

bifurcation opened this issue Apr 21, 2025 · 0 comments · Fixed by #60

Comments

@bifurcation
Copy link
Contributor

The last few PRs have made some unfortunate changes to the overall API. I merged #45 because the changes to Header are good, but factoring out ContextBase was a mistake. (For example, it's silly to track keys in one place and counters in another.) In #47, we added the custom non-allocating vector and map types, which should not be externally visible (cf. #50). We should clean this up, and make sure that sframe.h is as small and readable as possible. Even if we don't have doc generation (#1), we could at least have some more extensive comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant