Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Texts on Screen #252

Open
CanerKaraca23 opened this issue Dec 20, 2024 · 20 comments
Open

Weird Texts on Screen #252

CanerKaraca23 opened this issue Dec 20, 2024 · 20 comments

Comments

@CanerKaraca23
Copy link

CanerKaraca23 commented Dec 20, 2024

There is some weird texts on screen (i think it shows coordinats and it says ini file loaded on game opening screen), this happened after new RC release. I tried to delete cleo_tests folder (why this even exists on release package, is it related to debugging/development things?) and disabled logging on debug plugin .ini on plugins folder and still exists, it's annoying.

sa-mp-010

@MiranDMC
Copy link
Collaborator

Looks like something from SAMP itself or other mods (like display area names around radar). Clearly intentional texts, not some random data from memory.

Test sources act as examples for each opcode as way to debug on user's side. These can not be executed without compiling them first.

@CanerKaraca23
Copy link
Author

Looks like something from SAMP itself or other mods (like display area names around radar). Clearly intentional texts, not some random data from memory.

Test sources act as examples for each opcode as way to debug on user's side. These can not be executed without compiling them first.

Yeah, display area, FPS and stream usage things are my mods. I mention this, this from CLEO RC1, Beta 1 works fine:

sa-mp-010

@MiranDMC

@x87
Copy link

x87 commented Dec 20, 2024

show cleo.log

@CanerKaraca23
Copy link
Author

show cleo.log

.cleo.log

@x87

@x87
Copy link

x87 commented Dec 20, 2024

compass.cs? can you share this and other cleo scripts? one of them must have this code for on-screen coords

@CanerKaraca23
Copy link
Author

compass.cs? can you share this and other cleo scripts? one of them must have this code for on-screen coords

Sure, here all my cleo mods (you need CLEO+).

You should test with RC1 and Beta 1, Beta 1 works fine for me. @x87

cleo.zip

@MiranDMC
Copy link
Collaborator

MiranDMC commented Dec 20, 2024

Would be easier if you find the exact script causing it.
compass is just adding some blips to radar

@MiranDMC
Copy link
Collaborator

MiranDMC commented Dec 20, 2024

Looks like something from SAMP itself or other mods (like display area names around radar). Clearly intentional texts, not some random data from memory.
Test sources act as examples for each opcode as way to debug on user's side. These can not be executed without compiling them first.

Yeah, display area, FPS and stream usage things are my mods. I mention this, this from CLEO RC1, Beta 1 works fine:

sa-mp-010

@MiranDMC

Looks like some debug text. I would say from ambient sounds mod. Coords, area name and some ambient params?

@CanerKaraca23
Copy link
Author

Looks like something from SAMP itself or other mods (like display area names around radar). Clearly intentional texts, not some random data from memory.
Test sources act as examples for each opcode as way to debug on user's side. These can not be executed without compiling them first.

Yeah, display area, FPS and stream usage things are my mods. I mention this, this from CLEO RC1, Beta 1 works fine:
sa-mp-010
@MiranDMC

Looks like some debug text. I would say from ambient sounds mod. Coords, area name and some ambient params?

Yeah, i just tested the mods one by one and it causes by SAAS (San Andreas Ambient Sounds) mod. I didn't uploaded this mod to .zip file because it's heavy (300mb). @MiranDMC @x87

@MiranDMC
Copy link
Collaborator

MiranDMC commented Dec 20, 2024

Your cleo log says it is not RC1 version. It does not list loaded ASI plugins, so it has to be older version.

If it is SAAS caused try rename it to *.cs4
I suspect this might be related to fixes in ini files handling opcodes.

@CanerKaraca23
Copy link
Author

Your cleo log says it is not RC1 version. It does not list loaded ASI plugins, so it has to be older version.

If it is SAAS caused try rename it to *.cs4 I suspect this might be related to fixes in ini files handling opcodes.

I firstly tried RC1, when i see the issue, installed latest CI build so test if its fixed on latest commits but still same, maybe thats why not saying the version on .log file.

Renaming it to .cs4 fixed the issue, but yeah, it's definitely something wrong between RC1 and SAAS. @MiranDMC

Mod Link: https://www.mixmods.com.br/2018/07/saas-san-andreas-ambient-sounds/

@x87
Copy link

x87 commented Dec 20, 2024

Can you upload cs only?

@CanerKaraca23
Copy link
Author

CanerKaraca23 commented Dec 20, 2024

Can you upload cs only?

Sure, here.

Edit: just realized that this mod also needs NewOpcodes.

SAAS.zip

@MiranDMC
Copy link
Collaborator

Your cleo log says it is not RC1 version. It does not list loaded ASI plugins, so it has to be older version.
If it is SAAS caused try rename it to *.cs4 I suspect this might be related to fixes in ini files handling opcodes.

I firstly tried RC1, when i see the issue, installed latest CI build so test if its fixed on latest commits but still same, maybe thats why not saying the version on .log file.

Renaming it to .cs4 fixed the issue, but yeah, it's definitely something wrong between RC1 and SAAS. @MiranDMC

Mod Link: https://www.mixmods.com.br/2018/07/saas-san-andreas-ambient-sounds/

I guess it parses the input file in some way expecting old undefined behaviors from opcodes, which were fixed in CLEO5 but are still supported in legacy mode. In new mode data is probably not processed and Junior displays debug message with coords not covered by ambient sounds.
SAAS should use CS4 mode anyway, as otherwise sounds volume will be corrected twice.

@x87
Copy link

x87 commented Dec 20, 2024

:SAAS_2530
4@ = Memory.GetVarPointer(18@)
memcpy 12@ {destination} 4@ {size} 48
13@ = AudioStream.GetVolume(22@)
Text.PrintFormattedNow("%.0f %.0f %.0f %s %.1f %i", 200, 10@, 11@, TIMERA, 12@, 13@, 31@)

no idea what triggers it yet

@x87
Copy link

x87 commented Dec 20, 2024

list of changes between beta.1 and rc.1
v5.0.0-beta.1...v5.0.0-RC1

@x87
Copy link

x87 commented Dec 20, 2024

I guess it's ini parsing 3203afc

@x87
Copy link

x87 commented Dec 20, 2024

:SAAS_917
1@ = 0
  3@ = IniFile.ReadInt("cleo\saas.ini", "SETTINGS", "turnOffRadio")
if 
  3@ == 1
goto_if_false @SAAS_993
set_local_var_bit_const 1@ {bitIndex} 2

:SAAS_993
  3@ = IniFile.ReadInt("cleo\saas.ini", "SETTINGS", "debugMode")
if 
  3@ == 1
goto_if_false @SAAS_1059
set_local_var_bit_const 1@ {bitIndex} 0

if debugMode is not present, value of 3@ is not changed and remains 1 (because turnOffRadio=1)

@MiranDMC

@MiranDMC
Copy link
Collaborator

:SAAS_917
1@ = 0
  3@ = IniFile.ReadInt("cleo\saas.ini", "SETTINGS", "turnOffRadio")
if 
  3@ == 1
goto_if_false @SAAS_993
set_local_var_bit_const 1@ {bitIndex} 2

:SAAS_993
  3@ = IniFile.ReadInt("cleo\saas.ini", "SETTINGS", "debugMode")
if 
  3@ == 1
goto_if_false @SAAS_1059
set_local_var_bit_const 1@ {bitIndex} 0

if debugMode is not present, value of 3@ is not changed and remains 1 (because turnOffRadio=1)

@MiranDMC

Yes, as it is meant to be. Target value should be not changed, unless ReadInt succeed and returned condition result true.
In older CLEO ReadFloat was working in that way, meanwhile ReadInt was returning 0x80000000 as indicator of error.
This behavior is preserved in legacy modes.

@x87
Copy link

x87 commented Dec 20, 2024

@MiranDMC please write a doc that describes all places where the behavior was changed and CS4 mode can help. We throw in too much into "just rename to .cs4" and it's hard to track all cases.

Something like:

opcode xxxx
in CLEO4 returns X when not found
in CLEO5 keeps the same value, condition flag is false

opcode YYYY
in CLEO4 all arguments are required
in CLEO5 all arguments are optional

etc

This doc may help to triage the issues and for script authors to focus on specific problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants