-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Can't sort table #280
Comments
Hello! Thank you for pointing out the bug. Love the detailing! Definitely an improvement from our end. We will update this thread as soon as we have a PR for it! |
Can anyone please guide me through this issue, I would like to work on this and require a point to start with. |
@HarshDodiya1 thanks for picking this issue! We currently only support sorting in frontend (this was done for smaller tables - dev - majorly). To achieve sorting at a query level, you would need to send the sortBy column name to the GraphQL query made. This way you will ensure that the entire data received is sorted in the correct order. You would have to make changes to this "useGetStorageUnitRowsLazyQuery" (like we have where, pageSize, and pageOffset - you would need sortBy). Similarly, add this capability to the backend in all the plugins for all the databases (as we need to sort across the board). Hope this helps! |
hi @HarshDodiya1 , I wanted to see how you were getting along, if you're still working on the issue :) |
Hello, @modelorona! I hope you're doing well. I wanted to give you an update regarding the issue I’ve been working on. I was a step away for a while due to exams, but here’s what I have completed till now: Changes that I made:
When I run the GraphQL code generation command to regenerate the types and queries, I get the following error in the terminal: (node:26548) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✔ Parse Configuration
⚠ Generate outputs
❯ Generate to src/generated/graphql.tsx
✖
Failed to load schema from http://localhost:8080/api/query:
Unexpected response: "Unauthorized\n…
◼ Load GraphQL documents
◼ Generate
ELIFECYCLE Command failed with exit code 1. Can you please guide me on how to resolve this issue? I hope this make sense, and let me know if you need any code or further details. |
@HarshDodiya1 Apologies for the delayed response, had some personal stuff to handle :) This is something we have been meaning to modify to make it easier, but for now you can go to this should get around that auth issue when trying to regenerate the GraphQL files. Let me know if it does not work! |
@HarshDodiya1 we pushed out some code in the latest version that should let you update the graphql stuff w/o having to do the workaround above. Let me know if it's still acting up. |
Oh, thanks, @modelorona I will let you know about the updates soon. |
Describe the bug
When viewing a table (Postgres), I can click on the column headers, which kind of sorts the items, but only whatever is visible on that page of (by default) 100 rows. There doesn't seem to be a way to sort the whole table.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Being able to sort them whichever way we want, and to sort the whole table.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: