Add SMART status to overview page

Author: tomasmatus

pkg/systemd/overview-cards/healthCard.tsx

@@ -28,6 +28,7 @@ import LastLogin from "./lastLogin.jsx";
 import { CryptoPolicyStatus } from "./cryptoPolicies.jsx";
 
 import "./healthCard.scss";
+import { SmartOverviewStatus } from './smart-status.jsx';
 
 const _ = cockpit.gettext;
 
@@ -40,6 +41,7 @@ export const HealthCard = () =>
                 <InsightsStatus />
                 <CryptoPolicyStatus />
                 <ShutDownStatus />
+                <SmartOverviewStatus />
                 <LastLogin />
             </ul>
         </CardBody>

pkg/systemd/overview-cards/smart-status.jsx

@@ -0,0 +1,98 @@
+/*
+ * This file is part of Cockpit.
+ *
+ * Copyright (C) 2025 Red Hat, Inc.
+ *
+ * Cockpit is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
+ * (at your option) any later version.
+ *
+ * Cockpit is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with Cockpit; If not, see <https://www.gnu.org/licenses/>.
+ */
+
+import React from 'react';
+
+import { Button } from "@patternfly/react-core/dist/esm/components/Button/index.js";
+import { ExclamationCircleIcon } from "@patternfly/react-icons";
+import { Flex } from "@patternfly/react-core/dist/esm/layouts/Flex/index.js";
+import { Icon } from '@patternfly/react-core/dist/esm/components/Icon/index.js';
+
+import cockpit from "cockpit";
+import { useEvent, useInit } from 'hooks';
+
+const _ = cockpit.gettext;
+
+function countFailingDisks(proxies) {
+    const sataFail = Object.keys(proxies.drives_ata).reduce((acc, drive) => {
+        const smart = proxies.drives_ata[drive];
+        if (smart.SmartFailing) {
+            return acc + 1;
+        } else {
+            return acc;
+        }
+    }, 0);
+
+    const nvmeFail = Object.keys(proxies.nvme_controller).reduce((acc, drive) => {
+        const smart = proxies.nvme_controller[drive];
+        if (smart.SmartCriticalWarning.length > 0) {
+            return acc + 1;
+        } else {
+            return acc;
+        }
+    }, 0);
+
+    return sataFail + nvmeFail;
+}
+
+const udisksdbus = cockpit.dbus("org.freedesktop.UDisks2", { superuser: "try" });
+const proxies = {
+    drives_ata: null,
+    nvme_controller: null,
+};
+
+export const SmartOverviewStatus = () => {
+    useEvent(udisksdbus, "notify");
+
+    useInit(async () => {
+        const addProxy = (iface) => {
+            return udisksdbus.proxies("org.freedesktop.UDisks2." + iface, "/org/freedesktop/UDisks2");
+        };
+
+        proxies.drives_ata = addProxy("Drive.Ata");
+        proxies.nvme_controller = addProxy("NVMe.Controller");
+        await Promise.all(Object.keys(proxies).map(proxy => proxies[proxy].wait()));
+    });
+
+    if (proxies.drives_ata === null || proxies.nvme_controller === null) {
+        return;
+    }
+
+    const failingDisks = countFailingDisks(proxies);
+    if (failingDisks === 0) {
+        return;
+    }
+
+    return (
+        <li id="smart-status">
+            <Flex spaceItems={{ default: 'spaceItemsSm' }}>
+                <Icon status="danger">
+                    <ExclamationCircleIcon />
+                </Icon>
+                <Button variant="link" component="a" isInline
+                    onClick={ ev => { ev.preventDefault(); cockpit.jump("/storage") } }
+                >
+                    {cockpit.format(cockpit.ngettext("$0 disk is failing",
+                                                     "$0 disks are failing", failingDisks),
+                                    failingDisks)}
+                </Button>
+            </Flex>
+        </li>
+    );
+};

test/verify/check-storage-smart

@@ -42,10 +42,10 @@ class TestStorageSmart(storagelib.StorageSmartCase):
 
         return version > (2, 10, 1)
 
-    def testSmart(self):
-        def set_smart_dump(name: str, block: str):
-            self.machine.execute(f"udisksctl smart-simulate -f /tmp/smart-dumps/{name} -b {block}")
+    def set_smart_dump(self, name: str, block: str):
+        self.machine.execute(f"udisksctl smart-simulate -f /tmp/smart-dumps/{name} -b {block}")
 
+    def testSmart(self):
         def check_smart_info(assessment: str, hours: str, status: str, bad_sectors: str | None = None,
                              failing_attrs: str | None = None):
             self.assertIn(assessment, b.text(self.card_desc("Device health (SMART)", "Assessment")))
@@ -66,7 +66,7 @@ class TestStorageSmart(storagelib.StorageSmartCase):
 
         m.upload(["verify/files/smart-dumps"], "/tmp")
         # new disk, no failing sectors
-        set_smart_dump("MCCOE64GEMPP--2.9.09", "/dev/sda")
+        self.set_smart_dump("MCCOE64GEMPP--2.9.09", "/dev/sda")
 
         self.login_and_go("/storage")
         b.wait_visible(self.card("Storage"))
@@ -75,23 +75,23 @@ class TestStorageSmart(storagelib.StorageSmartCase):
         check_smart_info("Disk is OK", "1 hours", "Successful")
 
         # Disk with running self test
-        set_smart_dump("SAMSUNG_MMCQE28G8MUP--0VA_VAM08L1Q", "/dev/sda")
+        self.set_smart_dump("SAMSUNG_MMCQE28G8MUP--0VA_VAM08L1Q", "/dev/sda")
         check_smart_info("Disk is OK", "2417 hours", "In progress, 30%")
 
         # Interrupted self test, disk is OK
-        set_smart_dump("INTEL_SSDSA2MH080G1GC--045C8820", "/dev/sda")
+        self.set_smart_dump("INTEL_SSDSA2MH080G1GC--045C8820", "/dev/sda")
         check_smart_info("Disk is OK", "2309 hours", "Interrupted")
 
         # Aborted self test and has known bad sector
-        set_smart_dump("ST9160821AS--3.CLH", "/dev/sda")
+        self.set_smart_dump("ST9160821AS--3.CLH", "/dev/sda")
         check_smart_info("Disk is failing", "556 hours", "Aborted", bad_sectors="1")
 
         # Multiple bad sectors
-        set_smart_dump("Maxtor_96147H8--BAC51KJ0", "/dev/sda")
+        self.set_smart_dump("Maxtor_96147H8--BAC51KJ0", "/dev/sda")
         check_smart_info("Disk is failing", "2016 hours", "Successful", bad_sectors="71")
 
         # Multiple bad sectors with failing attribute
-        set_smart_dump("Maxtor_96147H8--BAC51KJ0--2", "/dev/sda")
+        self.set_smart_dump("Maxtor_96147H8--BAC51KJ0--2", "/dev/sda")
         check_smart_info("Disk is failing", "2262 hours", "Successful", bad_sectors="71", failing_attrs="1")
 
         # Check that SMART card is not visible on DVD drive
@@ -100,6 +100,33 @@ class TestStorageSmart(storagelib.StorageSmartCase):
         b.wait_visible(self.card("Media drive"))
         b.wait_not_present(self.card("Device health (SMART)"))
 
+    def testSmartOverview(self):
+        m = self.machine
+        b = self.browser
+
+        # udisks2 version > 2.10.1 is required to mock SMART data on virtual disks
+        if not self.udisks_mock_smart_supported():
+            stderr.write("Image has old udisks2 version, cannot run SMART test.\n")
+            return
+
+        m.upload(["verify/files/smart-dumps"], "/tmp")
+        # Failing disk, storage page is not loaded
+        self.set_smart_dump("Maxtor_96147H8--BAC51KJ0--2", "/dev/sda")
+        self.login_and_go("/system")
+        b.wait_in_text("#smart-status", "1 disk is failing")
+
+        self.set_smart_dump("MCCOE64GEMPP--2.9.09", "/dev/sda")
+        b.wait_not_present("#smart-status")
+
+        # Clicking the link navigates to storage page, failing disk has red icon
+        self.set_smart_dump("Maxtor_96147H8--BAC51KJ0", "/dev/sda")
+        b.wait_in_text("#smart-status", "1 disk is failing")
+        b.click("#smart-status a")
+        b.enter_page("/storage")
+        b.wait_visible(self.card("Storage"))
+        b.wait_visible(self.card_row("Storage", name="sda"))
+        b.wait_visible(self.card_row("Storage", name="sda") + " .ct-icon-times-circle")
+
 
 if __name__ == '__main__':
     testlib.test_main()