Skip to content

Commit 7f636e7

Browse files
SludgeGirlSludgeGirl
committed
test: Skip tests that are unsupported on Tumbleweed
1 parent 142d1e6 commit 7f636e7

25 files changed

+51
-0
lines changed

‎test/verify/check-apps

+3
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ class TestApps(packagelib.PackageCase):
8080
# ignore the corresponding journal entry
8181
self.allow_journal_messages("org.freedesktop.PackageKit.*org.freedesktop.DBus.Error.NoReply.*")
8282

83+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
8384
def testBasic(self, urlroot=""):
8485
b = self.browser
8586
m = self.machine
@@ -139,9 +140,11 @@ class TestApps(packagelib.PackageCase):
139140
b.wait_visible(f".app-list .pf-v5-c-data-list__item-row:contains('app-1') img[src^='{urlroot}/cockpit/channel/']")
140141
m.execute("! test -f /stamp-app-1-1.0-1")
141142

143+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
142144
def testWithUrlRoot(self):
143145
self.testBasic(urlroot="/webcon")
144146

147+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
145148
def testOsMap(self):
146149
b = self.browser
147150
m = self.machine

‎test/verify/check-client

+2
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,13 @@ exec "$@"
9494
self.m_target.execute("while pgrep -af '([c]ockpit|[s]sh-agent)' >&2; do sleep 1; done",
9595
timeout=30)
9696

97+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
9798
def testBeibootNoBridge(self):
9899
# set up target machine: no cockpit
99100
self.m_target.execute("rm /usr/bin/cockpit-bridge; rm -r /usr/share/cockpit")
100101
self.checkLoginScenarios()
101102

103+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
102104
def testBeibootWithBridge(self):
103105
self.checkLoginScenarios()
104106

‎test/verify/check-connection

+2
Original file line numberDiff line numberDiff line change
@@ -1408,6 +1408,7 @@ ProtocolHeader = X-Forwarded-Proto
14081408

14091409
@testlib.skipImage("nginx not installed", "centos-*", "rhel-*", "debian-*", "ubuntu-*", "arch")
14101410
@testlib.skipOstree("nginx not installed")
1411+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
14111412
def testNginxTLS(self):
14121413
"""test proxying to Cockpit with TLS
14131414
@@ -1488,6 +1489,7 @@ server {
14881489

14891490
@testlib.skipImage("nginx not installed", "centos-*", "rhel-*", "debian-*", "ubuntu-*", "arch")
14901491
@testlib.skipOstree("nginx not installed")
1492+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
14911493
def testNginxNoTLS(self):
14921494
"""test proxying to Cockpit with plain HTTP
14931495

‎test/verify/check-kdump

+1
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,7 @@ class TestKdumpNFS(KdumpHelpers):
490490
"nfs": {"image": TEST_OS_DEFAULT, "address": "10.111.113.2/24", "memory_mb": 512}
491491
}
492492

493+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
493494
def testBasic(self):
494495
m = self.machine
495496
b = self.browser

‎test/verify/check-metrics

+2
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ class TestHistoryMetrics(testlib.MachineCase):
181181
b.enter_page("/system")
182182
b.wait_visible('.system-information')
183183

184+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
184185
def testEvents(self):
185186
b = self.browser
186187
m = self.machine
@@ -1279,6 +1280,7 @@ BEGIN {{
12791280
class TestMetricsPackages(packagelib.PackageCase):
12801281
pcp_dialog_selector = "#pcp-settings-modal"
12811282

1283+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
12821284
def testBasic(self):
12831285
b = self.browser
12841286
m = self.machine

‎test/verify/check-networkmanager-mac

+2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class TestNetworkingMAC(netlib.NetworkCase):
2828
"machine2": {"image": TEST_OS_DEFAULT, "address": "10.111.113.2/20", "dhcp": True, "memory_mb": 512}
2929
}
3030

31+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
3132
def testMac(self):
3233
b = self.browser
3334
m = self.machine
@@ -58,6 +59,7 @@ class TestNetworkingMAC(netlib.NetworkCase):
5859
else:
5960
b.wait_not_present("#network-interface-mac button")
6061

62+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
6163
def testBondMac(self):
6264
b = self.browser
6365
m = self.machine

‎test/verify/check-networkmanager-mtu

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import testlib
2323

2424
@testlib.nondestructive
2525
class TestNetworkingMTU(netlib.NetworkCase):
26+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
2627
def testMtu(self):
2728
b = self.browser
2829
m = self.machine

‎test/verify/check-networkmanager-settings

+2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class TestNetworkingSettings(netlib.NetworkCase):
2828
"machine2": {"image": TEST_OS_DEFAULT, "address": "10.111.113.2/20", "dhcp": True, "memory_mb": 512}
2929
}
3030

31+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
3132
def testNoConnectionSettings(self):
3233
b = self.browser
3334
m = self.machine
@@ -151,6 +152,7 @@ class TestNetworkingSettings(netlib.NetworkCase):
151152
for method in unsupported_ip6_methods:
152153
b.wait_not_present(f"#network-ip-settings-select-method option[value='{method}']")
153154

155+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
154156
def testOtherSettings(self):
155157
b = self.browser
156158
m = self.machine

‎test/verify/check-networkmanager-team

+2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import testlib
2828
@testlib.skipImage("team not supported", "centos-10*", "rhel-10*")
2929
@testlib.nondestructive
3030
class TestTeam(netlib.NetworkCase):
31+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
3132
def testBasic(self):
3233
b = self.browser
3334

@@ -90,6 +91,7 @@ class TestTeam(netlib.NetworkCase):
9091
self.wait_for_iface(iface1)
9192
self.wait_for_iface(iface2)
9293

94+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
9395
def testActive(self):
9496
b = self.browser
9597
m = self.machine

‎test/verify/check-packagekit

+9
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ echo -e "Loaded patch modules:\nkpatch_3_10_0_1062_1_1 [enabled]\n\nInstalled pa
264264
# Patches should be installed
265265
m.execute("rpm -q kpatch-patch-" + sanitized_kernel_ver)
266266

267+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
267268
@testlib.nondestructive
268269
def testBasic(self):
269270
# no security updates, no changelogs
@@ -418,6 +419,7 @@ echo -e "Loaded patch modules:\nkpatch_3_10_0_1062_1_1 [enabled]\n\nInstalled pa
418419
b.wait_text(self.update_text, "System is up to date")
419420

420421
@testlib.skipImage("TODO: Packagekit on Arch does not detect the pear update", "arch")
422+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
421423
@testlib.skipImage("tracer not available", *OSesWithoutTracer)
422424
def testTracer(self):
423425
b = self.browser
@@ -597,6 +599,7 @@ ExecStart=/usr/local/bin/{self.packageName}
597599

598600
@testlib.skipImage("Arch Linux does not start services by default", "arch")
599601
@testlib.skipImage("tracer not available", *OSesWithoutTracer)
602+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
600603
@testlib.nondestructive
601604
def testFailServiceRestart(self):
602605
b = self.browser
@@ -657,6 +660,7 @@ ExecStart=/usr/local/bin/{packageName}
657660
b.wait_visible("#restart-services-modal .pf-v5-c-alert")
658661

659662
@testlib.skipImage("No security changelog support in packagekit", "arch")
663+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
660664
def testInfoSecurity(self):
661665
b = self.browser
662666
m = self.machine
@@ -825,6 +829,7 @@ ExecStart=/usr/local/bin/{packageName}
825829
b.wait_visible("table.updates-history tbody:not(.pf-m-expanded)")
826830

827831
@testlib.skipImage("No security changelog support in packagekit", "arch")
832+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
828833
@testlib.nondestructive
829834
def testSecurityOnly(self):
830835
b = self.browser
@@ -865,6 +870,7 @@ ExecStart=/usr/local/bin/{packageName}
865870
self.check_nth_update(2, "secnocve", "1-2", "security", desc_matches=["Fix leak"])
866871

867872
@testlib.skipImage("No changelog support in Arch Linux", "arch")
873+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
868874
@testlib.nondestructive
869875
def testInfoTruncation(self):
870876
b = self.browser
@@ -960,6 +966,7 @@ ExecStart=/usr/local/bin/{packageName}
960966
b.wait_in_text(".curtains-ct h1", "Disconnected")
961967
self.wait_reboot()
962968

969+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
963970
@testlib.nondestructive
964971
def testUpdateError(self):
965972
b = self.browser
@@ -995,6 +1002,7 @@ ExecStart=/usr/local/bin/{packageName}
9951002
# not expecting any buttons
9961003
self.assertFalse(b.is_present("#app button"))
9971004

1005+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
9981006
@testlib.nondestructive
9991007
def testPackageKitCrash(self):
10001008
b = self.browser
@@ -1101,6 +1109,7 @@ ExecStart=/usr/local/bin/{packageName}
11011109
@testlib.skipImage("TODO: Arch Linux has no cockpit-ws package, it's in cockpit", "arch")
11021110
@testlib.skipWsContainer("no cockpit-ws package with cockpit/ws container")
11031111
class TestWsUpdate(NoSubManCase):
1112+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
11041113
def testBasic(self):
11051114
# The main case for this is that cockpit-ws itself gets upgraded, which
11061115
# restarts the service and terminates the connection. As we can't

‎test/verify/check-pages

+1
Original file line numberDiff line numberDiff line change
@@ -784,6 +784,7 @@ OnCalendar=daily
784784
b.wait_text("#received-type", "-")
785785
b.wait_text("#received-title", "-")
786786

787+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
787788
def testHistory(self):
788789

789790
b = self.browser

‎test/verify/check-session

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import testlib
2323
@testlib.nondestructive
2424
class TestSession(testlib.MachineCase):
2525

26+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
2627
def testBasic(self):
2728
m = self.machine
2829
b = self.browser

‎test/verify/check-shell-host-switching

+1
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ class TestHostSwitching(testlib.MachineCase, HostSwitcherHelpers):
153153
self.allow_restart_journal_messages()
154154
self.allow_hostkey_messages()
155155

156+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
156157
def testBasic(self):
157158
b = self.browser
158159
m1 = self.machines["machine1"]

‎test/verify/check-shell-keys

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ KEY = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIEAkRTvQCSEZNPXpA5bP82ilQn3TMeQ6z2NO3
2525

2626
@testlib.nondestructive
2727
class TestKeys(testlib.MachineCase):
28+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
2829
def testAuthorizedKeys(self):
2930
m = self.machine
3031
b = self.browser
@@ -148,6 +149,7 @@ class TestKeys(testlib.MachineCase):
148149

149150
# Possible workaround - ssh as `admin` and just do `m.execute()`
150151
@testlib.skipBrowser("Firefox cannot do `cockpit.spawn`", "firefox")
152+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
151153
def testPrivateKeys(self):
152154
b = self.browser
153155
m = self.machine

‎test/verify/check-shell-multi-machine

+3
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ class TestMultiMachine(testlib.MachineCase):
451451
self.assertEqual(200, http_code("/cockpit/@localhost/manifests.json"))
452452
self.assertEqual(403, http_code("/cockpit/@10.111.113.2/manifests.json"))
453453

454+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
454455
def testUrlRoot(self):
455456
b = self.browser
456457
m = self.machine
@@ -670,6 +671,7 @@ class TestMultiMachine(testlib.MachineCase):
670671

671672
self.allow_hostkey_messages()
672673

674+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
673675
def testTroubleshooting(self):
674676
b = self.browser
675677
m1 = self.machine
@@ -816,6 +818,7 @@ class TestMultiMachine(testlib.MachineCase):
816818
'.*: server offered unsupported authentication methods: .*')
817819

818820
@testlib.skipImage("TODO: Broken on Arch Linux", "arch")
821+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
819822
def testSshKeySetup(self):
820823
b = self.browser
821824
m1 = self.machine

‎test/verify/check-shell-multi-machine-key

+1
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ class TestMultiMachineKeyAuth(testlib.MachineCase):
116116

117117
# Possible workaround - ssh as `admin` and just do `m.execute()`
118118
@testlib.skipBrowser("Firefox cannot do `cockpit.spawn`", "firefox")
119+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
119120
def testBasic(self):
120121
b = self.browser
121122
m1 = self.machine

‎test/verify/check-ssh-api

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ class TestSshDialog(testlib.MachineCase):
4242
self.machine.execute("pkill -ef [s]sh.*ferny.*127.0.0.1")
4343

4444
@testlib.skipImage("FIXME: Assertion failed: UnknownHostDialog needs a host-key and host-fingerprint in error", "rhel-8-10")
45+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
4546
def testPassword(self):
4647
m = self.machine
4748
b = self.browser

‎test/verify/check-static-login

+4
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class TestLogin(testlib.MachineCase):
3939
b.set_layout("desktop")
4040

4141
# @testlib.skipBeiboot("no local cockpit PAM config in beiboot mode")
42+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
4243
def testBasic(self):
4344
m = self.machine
4445
b = self.browser
@@ -217,6 +218,7 @@ account required pam_succeed_if.so user ingroup %s""" % m.get_admin_group
217218
"noise-rc-.*")
218219

219220
@testlib.skipWsContainer("logs in via ssh, not cockpit-session")
221+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
220222
def testLogging(self):
221223
m = self.machine
222224
b = self.browser
@@ -831,6 +833,7 @@ EOF""")
831833
b.logout()
832834

833835
@testlib.skipWsContainer("root logins disabled by default with ssh")
836+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
834837
def testPamAccess(self):
835838
b = self.browser
836839
m = self.machine
@@ -1061,6 +1064,7 @@ matchrule = <SUBJECT>^DC=LAN,DC=COCKPIT,CN=alice$
10611064

10621065
# enable this once our cockpit/ws container can beiboot
10631066
@testlib.skipWsContainer("client setup does not work with ws container")
1067+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
10641068
def testSSH(self):
10651069
m = self.machine
10661070
b = self.browser

‎test/verify/check-storage-luks

+2
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,7 @@ class TestStorageNBDE(storagelib.StorageCase, packagelib.PackageCase):
536536
"tang": {"address": "10.111.112.5/20"}
537537
}
538538

539+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
539540
def testBasic(self):
540541
m = self.machine
541542
b = self.browser
@@ -720,6 +721,7 @@ class TestStorageNBDE(storagelib.StorageCase, packagelib.PackageCase):
720721
b.wait_not_present(panel + 'ul li:contains("Slot 1")')
721722

722723
@testlib.skipImage("TODO: don't know how to encrypt the rootfs", "debian-*", "ubuntu-*", "arch")
724+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
723725
# this doesn't work in ostree either, but we don't run storage tests there
724726
@testlib.skipWsContainer("newly built root doesn't contain ws container")
725727
@testlib.timeout(1200)

‎test/verify/check-storage-lvm2

+1
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,7 @@ class TestStorageLvm2(storagelib.StorageCase):
793793
wait_partial(4) # striped mirror has lost more than half and is kaputt
794794
wait_partial(6) # raid6 is finally toast as well
795795

796+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
796797
def testLvmOnLuks(self):
797798
b = self.browser
798799
m = self.machine

‎test/verify/check-storage-nfs

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import testlib
2525
@testlib.nondestructive
2626
class TestStorageNfs(storagelib.StorageCase):
2727

28+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
2829
def testNfsClient(self):
2930
m = self.machine
3031
b = self.browser

‎test/verify/check-superuser

+1
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ session include system-auth
350350
b.check_superuser_indicator("Limited access")
351351

352352
@testlib.skipBeiboot("no local overrides/PAM config in beiboot mode")
353+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
353354
def testMultipleBridgeConfig(self):
354355
b = self.browser
355356

‎test/verify/check-system-services

+1
Original file line numberDiff line numberDiff line change
@@ -1221,6 +1221,7 @@ Where=/fail
12211221
b.wait_js_cond('window.location.pathname == "/system/services"')
12221222

12231223
@testlib.nondestructive
1224+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
12241225
def testServicesThemeConsistency(self):
12251226
b = self.browser
12261227

‎test/verify/check-users

+4
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,7 @@ class TestAccounts(testlib.MachineCase):
460460
b.click("#accounts-list > thead > tr > th:nth-child(3) > button")
461461
check_column_sort("[data-label='ID']")
462462

463+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
463464
def testUserPasswords(self):
464465
b = self.browser
465466
m = self.machine
@@ -963,6 +964,7 @@ class TestAccounts(testlib.MachineCase):
963964
b.go("#/robert")
964965
b.wait_text("#account-shell", custom_shell)
965966

967+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
966968
def testUnprivileged(self):
967969
m = self.machine
968970
b = self.browser
@@ -1047,6 +1049,7 @@ class TestAccounts(testlib.MachineCase):
10471049
return value.strip()
10481050
return None
10491051

1052+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
10501053
def testExpire(self):
10511054
m = self.machine
10521055
b = self.browser
@@ -1144,6 +1147,7 @@ class TestAccounts(testlib.MachineCase):
11441147
self.assertEqual(self.accountExpiryInfo("scruffy", "Password expires"), "password must be changed")
11451148

11461149
@testlib.skipWsContainer("User is not shown as logged in with cockpit/ws")
1150+
@testlib.skipImage("TODO: support opensuse-tumbleweed", "*tumbleweed*")
11471151
def testAccountLogs(self):
11481152
b = self.browser
11491153
m = self.machine

0 commit comments

Comments
 (0)