Declare all variables on a separate line

This is generally a recommended style and found by biome.

Author: jelly

pkg/apps/application-list.jsx

@@ -143,7 +143,9 @@ export const ApplicationList = ({ metainfo_db, appProgress, appProgressTitle, ac
         }
     }
 
-    let refresh_progress, refresh_button, tbody;
+    let refresh_progress;
+    let refresh_button;
+    let tbody;
     if (progress) {
         refresh_progress = <ProgressBar id="refresh-progress" size="sm" data={progress} />;
         refresh_button = <CancelButton data={progress} />;

pkg/lib/credentials.ts

@@ -127,7 +127,9 @@ export class Keys extends EventTarget {
 
     #parse_key(line: string, items: Record<string, Key>): Key | undefined {
         const parts = line.trim().split(" ");
-        let id, type, comment;
+        let id;
+        let type;
+        let comment;
 
         /* SSHv1 keys */
         if (!isNaN(parseInt(parts[0], 10))) {

pkg/lib/journal.js

@@ -140,7 +140,8 @@ journal.journalctl = function journalctl(/* ... */) {
     let interval = null;
 
     function fire_streamers() {
-        let ents, i;
+        let ents;
+        let i;
         if (streamers.length && entries.length > 0) {
             ents = entries;
             entries = [];
@@ -347,7 +348,8 @@ journal.renderer = function renderer(output_funcs) {
     // line has been output so far, top_state and bottom_state point
     // to the same object.
 
-    let top_state, bottom_state;
+    let top_state;
+    let bottom_state;
 
     top_state = bottom_state = { };
 

pkg/lib/machine-info.js

@@ -130,7 +130,8 @@ function decode_proc_str(s) {
 }
 
 export function devicetree_info() {
-    let model, serial;
+    let model;
+    let serial;
 
     return Promise.all([
         // these succeed with content === null if files are absent

pkg/lib/packagekit.js

@@ -493,7 +493,9 @@ export function install_missing_packages(data, progress_cb) {
     if (!data || data.missing_ids.length === 0)
         return Promise.resolve();
 
-    let last_progress, last_info, last_name;
+    let last_progress;
+    let last_info;
+    let last_name;
 
     function report_progess() {
         progress_cb({

pkg/lib/service.js

@@ -136,7 +136,8 @@ export function proxy(name, kind) {
 
     cockpit.event_target(self);
 
-    let unit, details;
+    let unit;
+    let details;
     let wait_promise_resolve;
     const wait_promise = new Promise(resolve => { wait_promise_resolve = resolve });
 

pkg/metrics/metrics.jsx

@@ -1857,7 +1857,8 @@ class MetricsHistory extends React.Component {
         let nodata_alert = null;
         const lastHourIndex = this.state.hours.length - 1;
         if (!this.state.loading && this.state.hours.length > 0 && this.oldest_timestamp < this.state.hours[lastHourIndex]) {
-            let t1, t2;
+            let t1;
+            let t2;
             if (this.state.hours[lastHourIndex] - this.oldest_timestamp < 24 * MSEC_PER_H) {
                 t1 = timeformat.time(this.oldest_timestamp);
                 t2 = timeformat.time(this.state.hours[lastHourIndex]);

pkg/networkmanager/firewall.jsx

@@ -121,7 +121,8 @@ function serviceRow(props) {
         });
     }
 
-    let description, includes;
+    let description;
+    let includes;
     if (props.service.description)
         description = <p>{props.service.description}</p>;
 

pkg/networkmanager/network-interface.jsx

@@ -165,7 +165,8 @@ export const NetworkInterfacePage = ({
     }
 
     function renderDesc() {
-        let desc, cs;
+        let desc;
+        let cs;
         if (dev) {
             if (dev.DeviceType == 'ethernet' || dev.IdVendor || dev.IdModel) {
                 desc = cockpit.format("$IdVendor $IdModel $Driver", dev);

pkg/networkmanager/wireguard.jsx

@@ -140,7 +140,8 @@ export function WireGuardDialog({ settings, connection, dev }) {
         // Validate Addresses before submit
         // Also validate listenPort as PF TextInput[type=number] accepts normal text as well on firefox
         // See - https://github.com/patternfly/patternfly-react/issues/9391
-        let addr, peersArr;
+        let addr;
+        let peersArr;
         const listen_port = Number(listenPort);
         try {
             addr = stringToAddresses(addresses);

pkg/packagekit/history.jsx

@@ -56,7 +56,8 @@ export class History extends React.Component {
      */
     mergeHistory() {
         const history = [];
-        let prevTime, prevPackages;
+        let prevTime;
+        let prevPackages;
 
         for (let i = 0; i < this.props.packagekit.length; ++i) {
             const packages = Object.keys(this.props.packagekit[i]).filter(i => i != "_time");

pkg/packagekit/updates.jsx

@@ -1354,7 +1354,9 @@ class OsUpdates extends React.Component {
     }
 
     renderContent() {
-        let applySecurity, applyKpatches, applyAll;
+        let applySecurity;
+        let applyKpatches;
+        let applyAll;
 
         /* On unregistered RHEL systems we need some heuristics: If the "main" OS repos (which provide coreutils) require
          * a subscription, then point this out and don't show available updates, even if there are some auxiliary

pkg/shell/failures.tsx

@@ -117,7 +117,8 @@ export const Disconnected = ({ problem }) => {
 
 export const MachineTroubleshoot = ({ machine, onClick }) => {
     const connecting = (machine.state == "connecting");
-    let title, message;
+    let title;
+    let message;
     if (machine.restarting) {
         title = _("The machine is rebooting");
         message = "";

pkg/shell/router.jsx

@@ -131,7 +131,8 @@ export function Router(callbacks) {
     }
 
     function register(child) {
-        let host, page;
+        let host;
+        let page;
         const name = child.name || "";
         if (name.indexOf("cockpit1:") === 0) {
             const parts = name.substring(9).split("/");
@@ -187,7 +188,8 @@ export function Router(callbacks) {
         if (typeof data !== "string")
             return;
 
-        let source, control;
+        let source;
+        let control;
 
         /*
          * On Internet Explorer we see Access Denied when non Cockpit

pkg/shell/util.tsx

@@ -220,7 +220,8 @@ function component_checksum(machine: Machine, path: string): string | undefined
 }
 
 export function compute_frame_url(machine: Machine, path: string): string {
-    let base, checksum;
+    let base;
+    let checksum;
     if (machine.manifests && machine.manifests[".checksum"])
         checksum = "$" + machine.manifests[".checksum"];
     else

pkg/static/login.js

@@ -69,7 +69,10 @@ function debug(...args) {
 
     const _ = gettext;
 
-    let login_path, application, org_login_path, org_application;
+    let login_path;
+    let application;
+    let org_login_path;
+    let org_application;
     const qs_re = /[?&]?([^=]+)=([^&]*)/g;
     let oauth_redirect_to = null;
 

pkg/storaged/block/resize.jsx

@@ -44,7 +44,8 @@ export function check_unused_space(path) {
     const lvol = lvm2 && client.lvols[lvm2.LogicalVolume];
     const part = client.blocks_part[path];
 
-    let size, min_change;
+    let size;
+    let min_change;
 
     if (lvol) {
         size = lvol.Size;
@@ -235,7 +236,9 @@ function lvol_or_part_and_fsys_resize(client, lvol_or_part, size, offline, passp
 }
 
 export function get_resize_info(client, block, to_fit) {
-    let info, shrink_excuse, grow_excuse;
+    let info;
+    let shrink_excuse;
+    let grow_excuse;
 
     if (block) {
         if (block.IdUsage == 'crypto' && client.blocks_crypto[block.path]) {
@@ -337,8 +340,17 @@ export function free_space_after_part(client, part) {
 }
 
 export function grow_dialog(client, lvol_or_part, info, to_fit) {
-    let title, block, name, orig_size, max_size, allow_infinite, round_size;
-    let has_subvols, subvols, pvs_as_spaces, initial_pvs;
+    let title;
+    let block;
+    let name;
+    let orig_size;
+    let max_size;
+    let allow_infinite;
+    let round_size;
+    let has_subvols;
+    let subvols;
+    let pvs_as_spaces;
+    let initial_pvs;
 
     function compute_max_size(spaces) {
         const layout = lvol_or_part.Layout;
@@ -543,7 +555,11 @@ export function grow_dialog(client, lvol_or_part, info, to_fit) {
 }
 
 export function shrink_dialog(client, lvol_or_part, info, to_fit) {
-    let title, block, name, orig_size, round_size;
+    let title;
+    let block;
+    let name;
+    let orig_size;
+    let round_size;
 
     if (lvol_or_part.iface == "org.freedesktop.UDisks2.LogicalVolume") {
         const vgroup = client.vgroups[lvol_or_part.VolumeGroup];

pkg/storaged/client.js

@@ -433,7 +433,17 @@ function is_toplevel_drive(block) {
 }
 
 function update_indices() {
-    let path, block, mdraid, vgroup, pvol, lvol, pool, blockdev, fsys, part, i;
+    let path;
+    let block;
+    let mdraid;
+    let vgroup;
+    let pvol;
+    let lvol;
+    let pool;
+    let blockdev;
+    let fsys;
+    let part;
+    let i;
 
     client.broken_multipath_present = false;
     client.drives_multipath_blocks = { };

pkg/storaged/crypto/encryption.jsx

@@ -133,7 +133,8 @@ const EncryptionCard = ({ card, block }) => {
                                 [block]);
     useEvent(luks_info, "changed");
 
-    let old_options, passphrase_path;
+    let old_options;
+    let passphrase_path;
     const old_config = block.Configuration.find(c => c[0] == "crypttab");
     if (old_config) {
         old_options = (decode_filename(old_config[1].options.v)

pkg/storaged/dialog.jsx

@@ -1038,7 +1038,8 @@ class SizeSliderElement extends React.Component {
             onChange({ text: value, unit });
         };
 
-        let slider_val, text_val;
+        let slider_val;
+        let text_val;
         if (val.text && val.unit) {
             slider_val = Number(val.text) * val.unit;
             text_val = val.text;

pkg/storaged/partitions/partition-table.jsx

@@ -66,7 +66,8 @@ function make_partition_pages(parent, block) {
     }
 
     function process_partitions(parent, partitions, enable_dos_extended) {
-        let i, p;
+        let i;
+        let p;
         for (i = 0; i < partitions.length; i++) {
             p = partitions[i];
             if (p.type == 'free')

pkg/storaged/utils.js

@@ -73,7 +73,8 @@ export function extract_option(split, opt) {
 }
 
 export function edit_crypto_config(block, modify) {
-    let old_config, new_config;
+    let old_config;
+    let new_config;
 
     function commit() {
         new_config[1]["track-parents"] = { t: 'b', v: true };
@@ -306,7 +307,9 @@ export function drive_name(drive) {
 }
 
 export function get_block_link_parts(client, path) {
-    let is_part, is_crypt, is_lvol;
+    let is_part;
+    let is_crypt;
+    let is_lvol;
 
     while (true) {
         if (client.blocks_part[path] && client.blocks_ptable[client.blocks_part[path].Table]) {
@@ -326,7 +329,8 @@ export function get_block_link_parts(client, path) {
     if (!block)
         return;
 
-    let location, link;
+    let location;
+    let link;
     if (client.mdraids[block.MDRaid]) {
         location = ["mdraid", client.mdraids[block.MDRaid].UUID];
         link = cockpit.format(_("MDRAID device $0"), mdraid_name(client.mdraids[block.MDRaid]));
@@ -384,7 +388,11 @@ export function get_partitions(client, block) {
         let n;
         let last_end = container_start;
         const total_end = container_start + container_size;
-        let block, start, size, is_container, is_contained;
+        let block;
+        let start;
+        let size;
+        let is_container;
+        let is_contained;
 
         const result = [];
 
@@ -517,7 +525,10 @@ export function get_available_spaces(client) {
 
     function add_free_spaces(block) {
         const parts = get_partitions(client, block);
-        let i, p, link_parts, text;
+        let i;
+        let p;
+        let link_parts;
+        let text;
         for (i in parts) {
             p = parts[i];
             if (p.type == 'free') {

pkg/systemd/overview-cards/insights.jsx

@@ -176,7 +176,8 @@ export class InsightsStatus extends React.Component {
         else
             url = "https://console.redhat.com/insights";
 
-        let icon, text;
+        let icon;
+        let text;
         if (this.state.hits) {
             const n = this.state.hits.n;
             if (n == 0) {

pkg/systemd/overview-cards/tuned-dialog.jsx

@@ -200,7 +200,8 @@ const TunedDialog = ({
         const withInfo = (active, recommended, profiles) => {
             const model = [];
             profiles.forEach(p => {
-                let name, desc;
+                let name;
+                let desc;
                 if (typeof p === "string") {
                     name = p;
                     desc = "";