Skip to content

Commit b88dcb8

Browse files
committed
improve udisks version check, skip test on ubuntu, debian
1 parent f4d2280 commit b88dcb8

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

test/verify/check-storage-smart

+5-8
Original file line numberDiff line numberDiff line change
@@ -23,26 +23,23 @@ import storagelib
2323
import testlib
2424

2525

26+
@testlib.skipImage("Debian and Ubuntu does not boot, drive is not detected.", "debian-*", "ubuntu-*")
2627
class TestStorageSmart(storagelib.StorageSmartCase):
2728

2829
def udisks_mock_smart_supported(self):
2930
m = self.machine
3031
# udisks2 version > 2.10.1 is required to mock SMART data on virtual disks
3132
if m.image.startswith("fedora") or m.image.startswith("rhel") or m.image.startswith("centos"):
32-
# udisks2-2.10.1-6.fc41.x86_64
33-
version_str = self.machine.execute("rpm -q udisks2").strip()
34-
version = tuple(int(v) for v in version_str.split('-')[1].split('.'))
33+
version_str = self.machine.execute("rpm -q udisks2 --qf '%{NAME} %{VERSION}\n'").strip()
3534
elif m.image.startswith("debian") or m.image.startswith("ubuntu"):
36-
# udisks2/stable,now 2.9.4-4 amd64 [installed]
37-
version_str = self.machine.execute("apt list --installed udisks2").strip()
38-
version = tuple(int(v) for v in version_str.split()[1].split('-')[0].split('.'))
35+
version_str = self.machine.execute("dpkg-query -f '${Package} ${Version}\n' --show udisks2").strip()
3936
elif m.image == "arch":
40-
# udisks2 2.10.1-5
4137
version_str = self.machine.execute("pacman -Q udisks2").strip()
42-
version = tuple(int(v) for v in version_str.split()[1].split('-')[0].split('.'))
4338
else:
4439
return False
4540

41+
version = tuple(int(v) for v in version_str.split()[1].split('-')[0].split('.'))
42+
4643
return version > (2, 10, 1)
4744

4845
def testSmart(self):

0 commit comments

Comments
 (0)